Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(maths): add matrix multiplication #211

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Feat(maths): add matrix multiplication #211

merged 2 commits into from
Oct 20, 2023

Conversation

R055A
Copy link
Contributor

@R055A R055A commented Oct 19, 2023

Ref #10

Add new implementation for matrix-matrix, matrix-vector and matrix-scalar multiplication.

@R055A R055A mentioned this pull request Oct 19, 2023
Open
41 tasks
appgurueu
appgurueu approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though I don't really think "overloading" one function is necessarily the best design - separate functions may be cleaner. The if - else - if - else tree could be converted to a bunch of early returns.

@raklaptudirm raklaptudirm merged commit bb7afaa into TheAlgorithms:master Oct 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raklaptudirm raklaptudirm raklaptudirm approved these changes

@appgurueu appgurueu appgurueu approved these changes

@Panquesito7 Panquesito7 Awaiting requested review from Panquesito7 Panquesito7 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@R055A @appgurueu @raklaptudirm