Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

algorithm: find min #61

Merged
merged 1 commit into from
Oct 16, 2022
Merged

algorithm: find min #61

merged 1 commit into from
Oct 16, 2022

Conversation

Psytew
Copy link
Contributor

@Psytew Psytew commented Oct 15, 2022

#10 : Adding IsMin feature, one of several requested.

appgurueu
appgurueu requested changes Oct 15, 2022
View reviewed changes
Copy link
Contributor

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function should be called findMin or just min; a function called isMin would be expected to check whether a number is the minimum.

appgurueu
appgurueu reviewed Oct 15, 2022
View reviewed changes
Maths/IsMin.ts Outdated Show resolved Hide resolved
@Psytew
Copy link
Contributor Author

Psytew commented Oct 15, 2022

PR is updated per the above comments.

@raklaptudirm raklaptudirm changed the title Feat: Added IsMin algorithm: find min Oct 16, 2022
@raklaptudirm raklaptudirm merged commit 12fa80b into TheAlgorithms:master Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu approved these changes

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Psytew @appgurueu @raklaptudirm