Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete-popup #114

Open
wants to merge 2 commits into
base: autocomplete-popup
Choose a base branch
from

Conversation

cyelis1224
Copy link
Collaborator

@cyelis1224 cyelis1224 commented Nov 24, 2024

ezgif-5-b5ae30e6f4

This is meant to resolve feature request from #38

It creates a popup for selecting from the list of available actors who have aliases set in unkenny. I had intended to include the tab and enter functionality that you had mentioned but it kept breaking how the text input field for the chat log worked. after selecting an alias from the popup the enter key would only create new lines and would no longer send messages to the chat. Does work via mouse selection just fine though.

I should clarify this probably isn't ready to actually merge but wondered if this was the direction to go in

make a popup to select from available actors who have unkenny alieases.
This will load the script for the autocomplete popup now.
@TheComamba
Copy link
Owner

Woah 😍. I thought this was one of those features that would not come within a year.
I mean, Tab completion is nice, but this is already a big step up in usability. If the new features are rudimentary testable I'd say we could probably merge a first version. If you feel comfy with it.
I'll have a look at your other PR first, and then turn towards this one.

@TheComamba TheComamba changed the base branch from main to autocomplete-popup December 1, 2024 17:26
@TheComamba
Copy link
Owner

Even though this is not ready to merge to main, I suggest to merge it to the original repository to ease collaboration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants