-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruby: Linting and RuboCop: Add minor clarifications and improvements #28828
base: main
Are you sure you want to change the base?
Conversation
Originally I absent-mindedly told people to run Wonder if the comment that gets generated automatically when running the command needs to be added to the code block or not: # The behavior of RuboCop can be controlled via the .rubocop.yml
# configuration file. It makes it possible to enable/disable
# certain cops (checks) and to alter their behavior if they accept
# any parameters. The file can be placed either in your home
# directory or in some project directory.
#
# RuboCop will start looking for the configuration file in the directory
# where the inspected file is and continue its way up to the root directory.
#
# See https://docs.rubocop.org/rubocop/configuration |
Interesting! Thanks for linking the original change. I see the confusing thing about the home folder
It is mentioned shortly in the section before it.
It was clear to me when I was following the section that it should be run in the project folder instead of the home folder when using it with bundle. And I don't think adding the whole auto-generated text to the lesson explicitly adds much. |
If a rethink of that section is necessary, do you want to consider it in the context or this PR, or do you want this to be assessed as is and another issue can be made for that? |
I think the small adjustments made in this PR are still relevant |
Because
Just some minor changes to improve consistency (e.g.
touch
ornano
while therubocop --init
was introduced in a previous paragraph).Also some punctuation and spacing to improve readability and limit confusion.
This PR
rubocop --init
commandIssue
Additional Information
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section