Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix improve this content on GitHub link #4147

Closed
wants to merge 2 commits into from

Conversation

Asartea
Copy link
Contributor

@Asartea Asartea commented Sep 16, 2023

Because

  • The current link points to a nonexistent file

This PR

  • Fixes the link

Issue

Closes #4101

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the keyword: brief description of change format, using one of the following keywords:
  • Feature - adds new or amends existing user-facing behavior
  • Chore - changes that have no user-facing value, refactors, dependency bumps, etc
  • Fix - bug fixes
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • I have verified all tests and linters pass after making these changes.
  • If this PR addresses an open issue, it is linked in the Issue section

@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-4147 September 17, 2023 14:48 Inactive
Copy link
Member

@KevinMulhern KevinMulhern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Asartea

Sidenote, during QA I noticed the community expectations page has the same issue. Would you be up for fixing that one in this PR too?

@KevinMulhern
Copy link
Member

Sorry for wasting your time with this one @Asartea, I didn't think we'd be getting this change in as quickly as we did. It changes the same area and fixes the issues this PR addresses. With it being the longer term way we want to handle the lesson footer links, it got the priority in this instance.

@Asartea
Copy link
Contributor Author

Asartea commented Sep 17, 2023

np

@Asartea Asartea deleted the patch-2 branch September 17, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Bug: broken link in rules page.
2 participants