-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Path2D as Module? #132
Comments
Because it was contributed that way in #45 🤷♂️ Yes, I'd accept a PR to add a new module. I am a couple of years overdue for publishing a 1.0 release, that seems like a good breaking change to have |
you didn't need to close this - your PR would automatically close it when merged. |
may add more canvas tests |
Merged
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Example of path2D as currently
After working with react rescript bindings would expect Path2D to be it's own module like
That would be a breaking change, however Path2D bindings seems currently on an early stage
Would a PR with those changes be accepted?
If so, would be possible to add all remaining Path2D method bindings to that module
Path2D.addPath()
Path2D.closePath()
Path2D.moveTo()
Path2D.lineTo()
Path2D.bezierCurveTo()
Path2D.quadraticCurveTo()
Path2D.arc()
Path2D.arcTo()
Path2D.ellipse()
Path2D.rect()
Path2D.roundRect()
The text was updated successfully, but these errors were encountered: