Path 2D module

[3xau1o]

As result of #132

Path2d module added with following js bindings, see on MDN

• addPath
• arc
• arcTo
• bezierCurveTo
• closePath
• ellipse
• lineTo
• moveTo
• quadraticCurveTo
• rect
• roundRect

Syntax

open Webapi.Canvas

let path1 = Path2d.make()
let path2 = Path2d.make(~d="M10 10 h 80 v 80 h -80 Z", ())

path1->Path2d.addPath(path2)

path1->Path2d.arc(~x=1.,~y =2.,~r=3.,~a1 = 4., ~a2 =5.,())

Changelog

• added Path2d module
• added Canvas2d ellipse roundRect bindings

Breaking

• Updated common Path2d/Canvas2d params names to match mdn docs

- ctx->quadraticCurveTo(~cp1x=1., ~cp1y=1., ~x=1., ~y=1.)
+ ctx->quadraticCurveTo(~cpx=1., ~cpy=1., ~x=1., ~y=1.)

- ctx->arc(~x=1., ~y=1., ~r=4., ~startAngle=1., ~endAngle=3., ~anticw =true)
+ ctx->arc(~x=1., ~y=1., ~r=4., ~startAngle=1., ~endAngle=3., ~counterClockWise=true, ())

• Added Path2d.make, Dropped Canvas2d.strokePath2D

- let path: path2d = newPath2D("M24.85,10.126c2.018-4.783,6.628-8.125,11.99-8.125c7.223")
+ let path = Path2d.make(~d="M24.85,10.126c2.018-4.783,6.628-8.125,11.99-8.125c7.223")

• Canvas2d functions taking Path2d renamed

- ctx->strokePath2D(path)
- ctx->fillPath2D(path)
+ ctx->strokePath2d(path1)
+ ctx->fillPath2d(path2)

TODO

• add Path2d module
• export Path2d from src/Webapi/Webapi__Canvas.res
• remove Canvas2d.newPath2D() in favor of Path2d.make(~d=?)
• add missing Canvas2d methods
• Updated canvas2s test
• extract common methods between Path2d and Context2D (Functor with parametric t)
• list breaking changes

[3xau1o]

@TheSpyder what do you do with the generated js files from tests? are they used besides compile check?

[TheSpyder]

@utenma sorry I haven't looked at this yet. The "tests" are indeed a compile check; it ensures changes made do not impact the compiled JS (unless that's intentional).

I hope to one day have full library coverage, if you could add a few extra test calls to methods you've added that would be great 👍

Should we delete the old binding methods you're replacing?

[TheSpyder]

Getting there! just needs a few tweaks.

[3xau1o]

updated list of breaking changes

[TheSpyder]

I am truly sorry for letting this sit for over 2 months. I had a long work trip and then things just kept coming up that I had to deal with first.

Just one little tweak and then I'll merge+release it.

[TheSpyder]

These don't have an equivalent test in your new code 🤔

[TheSpyder]

oh beginPath is already tested, and the others moved. My bad.

[TheSpyder]

Published as 0.10.0