Port to 1.21.1 NeoForge #91
Conversation
|
Thank you very much for your contribution. Also: is the original Forge project dead now? All the newly ported mods for 1.21 only support Neoforge. |
|
The team that used to work on Forge now work on NeoForge minus Lex https://neoforged.net/news/theproject/ I didn't know where to reach you so I sent you a message on Twitter and an email. I didn't send a Curse dm as you haven't opened curse in a few months |
|
The PR should be complete now. I had just forgotten to remove a temporary line in the build.gradle that I used to limit the dev client to 4gb of ram because I have 64gb of ram. Otherwise it'd allocate 25% aka 16gb which is way too much in my opinion) |
|
Is there anything else needed for this PR to get merged? If any other help is desired let me know |
|
Hey @Mrbysco if he is not interested in merging this can you make a fork of the mod? We would love it in ATM10! |
Just wanted to throw out we've been testing this internally at FTB and Bysco has ironed out the couple minor issues we found and its working perfectly now. If you get time to merge and release this the modding community would surely appreciate it, ty! |
|
I will release it this week, just want to do some more tests |
|
Can't wait!!! |
|
@Theta-Dev still looking good for a release this week? No stress we're just planning to release a major pack soon and need to figure out if we're including at launch or not. Thanks! |
Seems like the port got removed from Curseforge. |
|
Its been a month. I guess it won't be coming anytime this year. |
I was testing this build on my private server and it has a duplication bug: Blocks on off hand won't be spent, u can duplicate it forever |
|
where can i download the Neoforge 1.21.1 Version? |
|
i can maintain the project if you're too busy to do it yourself. |
I've offered the same by email, never got a reply 🤷♂️ |
really sad to see big projects like these neglected |
So am I :) I port when someone asks me to and my abilities allow it |
| Optional<IItemHandler> itemHandlerOptional = inventoryStack.getCapability(ForgeCapabilities.ITEM_HANDLER).resolve(); | ||
| if(itemHandlerOptional.isEmpty()) return 0; | ||
| IItemHandler itemHandler = inventoryStack.getCapability(Capabilities.ItemHandler.ITEM); | ||
| if(itemHandler != null) return 0; |
There was a problem hiding this comment.
This should be if(itemHandler == null)
|
|
||
| IItemHandler itemHandler = itemHandlerOptional.get(); | ||
| IItemHandler itemHandler = inventoryStack.getCapability(Capabilities.ItemHandler.ITEM); | ||
| if(itemHandler != null) return 0; |
There was a problem hiding this comment.
This should be if(itemHandler == null)
|
@whatthedrunk Looks like Mr Brysco ported it by updating and changing a few features and making them just sticks, calling it Construction Sticks. |
Yeah its added to ATM10 already. |
I've updated the mod to 1.21.1 and converted over from Forge to NeoForge.
I've commented out the Botania support since Botania isn't updated to 1.21 yet.