Update displayOperands to handle optional operands #17
Conversation
There was a problem hiding this comment.
I thought the operands were in-order in the JSON, but it turns out they aren't. They should be, which would make your implementation much easier.
I've opened an issue, ThinkOpenly/sail#26, to ensure the operands are in-order in the JSON.
Let's hold these changes until that is addressed. When that is addressed, I suspect your original approach would be sufficient, which I presume kept a single list of operands, "all", and just walked through the operands and appended to that list.
src/App.js
Outdated
| if (operands[i].optional) { | ||
| optional.push("[," + operands[i].name + "]"); | ||
| } else { | ||
| required.push(operands[i].name); | ||
| } |
There was a problem hiding this comment.
We don't have documented "code style" guidelines, but I suggest following the general approach elsewhere in the code, and use 4 spaces for each level of indentation. Here, only 1 space is used.
There was a problem hiding this comment.
I see...
I'll hold the changes for displayOperands till then.
4 spaces, got it!
Linda-Njau
force-pushed
the
main
branch
2 times, most recently
from
60c357e
to
7d1cb9b
Compare
|
Were you able to test this? |
|
Yes, I was able to test it. |
The displayOperands function previously did not distinguish between optional and required operands. This change updates the function to display optional operands within square brackets. `vd,vs2,vs1,[,vm]`
|
I've rebased this branch as well. |
Would it be convenient to get rid of that extra comma? To produce |
|
|
||
| for (let i = 0; i < operands.length; i++) { | ||
| if (operands[i].optional) { | ||
| all += comma + "[," + operands[i].name + "]"; |
There was a problem hiding this comment.
I suspect fixing the "extra comma" would entail something like:
all += "[" + comma + operands[i].name + "]";
The
displayOperandsfunction previously did not distinguish between optional and required operands. This change updates the function to display optional operands within square brackets and position them at the end of the operand list.