Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slidingfinished #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hellowilman
Copy link

I have add one signal to RangeSlider, which will emit when sliding finished.

  • slide the handler
  • click the axis
  • misc

it is implemented when the widget's mouseReleaseEvent is called.

wilman added 2 commits November 11, 2019 17:36
when sliding finished (by click / dragging the slider, etc.)
@ThisIsClark
Copy link
Owner

Have you ever verified it?

@hellowilman
Copy link
Author

Yes. I have the testing code, but I do not upload the testing code since i may override some other codes.
I will upload the testing code in next commit later soon. Thanks.

@ThisIsClark
Copy link
Owner

If you need to handle something when sliding finish, why not handle it in mouseReleaseEvent directly.
What's the difference between handling the things in mouseReleaseEvent and handling the things in the bound slot of slidingFinished signal.

@hellowilman
Copy link
Author

If you need to handle something when sliding finish, why not handle it in mouseReleaseEvent directly.
What's the difference between handling the things in mouseReleaseEvent and handling the things in the bound slot of slidingFinished signal.

Make it more QT style, which maybe easy to understand.
In fact, it is implemented via mouseReleaseEvent in the RangeSlider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants