Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pubsub.go #306

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

golang-boy
Copy link

no subscriber should return an error when publishing

no subscriber should return an error when publishing
fix mod name
@@ -1,4 +1,4 @@
module github.com/ThreeDotsLabs/watermill
module github.com/golang-boy/watermill
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
module github.com/golang-boy/watermill
module github.com/ThreeDotsLabs/watermill

Comment on lines +145 to +147
err := errors.New("No subscribers")
g.logger.Error("No subscribers to send message", err, logFields)
return ackedBySubscribers, err
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no error by design, as Publish drops the message if no subscribers are waiting for it. If you'd like to see an error in this case, we would need a configuration option not to change the current behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants