Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up resources related to the topic if there are no subscribers … #396

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Clean up resources related to the topic if there are no subscribers … #396

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b8438b
Clean up resources related to the topic if there are no subscribers …
stong1994 Sep 19, 2023
10a09da
Merge branch 'master' into master
stong1994 Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion pubsub/gochannel/pubsub.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,14 @@ func (g *GoChannel) Subscribe(ctx context.Context, topic string) (<-chan *messag
s.Close()

g.subscribersLock.Lock()
defer g.subscribersLock.Unlock()
defer func() {
// if there are no subscribers, clean up any resources related to the topic
if len(g.subscribers[topic]) == 0 {
delete(g.subscribers, topic)
g.subscribersByTopicLock.Delete(topic)
}
g.subscribersLock.Unlock()
}()

subLock, _ := g.subscribersByTopicLock.Load(topic)
subLock.(*sync.Mutex).Lock()
Expand Down