Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move problematic return statement out of for loop #403

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Darkskald
Copy link

The closure produced by addEventHandlersToRoute has a return statement inside the for loop which leads to a termination of the function in case of a successful event handling which is not the desired behavior if multiple handlers for the same event type are registered.

}

return nil
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return statement here skips the if below entirely, right? Is that on purpose?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants