#349 default to no load balancer so that in load balaner house we don…

…t always rebuild the loadbalancer infrastructure because the load balancer options type is null (#358)
ThreeMammals · May 15, 2018 · 061a90f · 061a90f
1 parent 1e2e953
commit 061a90f
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/src/Ocelot/Configuration/LoadBalancerOptions.cs b/src/Ocelot/Configuration/LoadBalancerOptions.cs
@@ -1,10 +1,12 @@
+using Ocelot.LoadBalancer.LoadBalancers;
+
 namespace Ocelot.Configuration
 {
     public class LoadBalancerOptions
     {
         public LoadBalancerOptions(string type, string key, int expiryInMs)
         {
-            Type = type;
+            Type = type ?? nameof(NoLoadBalancer);
             Key = key;
             ExpiryInMs = expiryInMs;
         }

diff --git a/test/Ocelot.UnitTests/LoadBalancer/LoadBalancerOptionsTests.cs b/test/Ocelot.UnitTests/LoadBalancer/LoadBalancerOptionsTests.cs
@@ -0,0 +1,17 @@
+using Ocelot.Configuration;
+using Ocelot.LoadBalancer.LoadBalancers;
+using Shouldly;
+using Xunit;
+
+namespace Ocelot.UnitTests.LoadBalancer
+{
+    public class LoadBalancerOptionsTests
+    {
+        [Fact]
+        public void should_default_to_no_load_balancer()
+        {
+            var options = new LoadBalancerOptionsBuilder().Build();
+            options.Type.ShouldBe(nameof(NoLoadBalancer));
+        }
+    }
+}