Colour handling improvements #8702
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The replacement library from https://colorjs.io/ is much, much larger but I think we can develop a custom build that uses treeshaking to whittle the code down to the bits that we need. @linonetwo does that sound feasible? I intend the explore further improvements but I wanted to start by establishing a library that can do modern P3 and OKLCH colour calculations.
Really just syntactic sugar for the wikify widget
Using the new wikify operator. Currently has a bug whereby redirected colours (like "tiddler-background") do not work. Direct colours like "background" do work. Note the hacks needed to makeFakeWidgetWithVariables work
|
Confirmed: Jermolene has already signed the Contributor License Agreement (see contributing.md) |
pmario
reviewed
Oct 25, 2024
| @@ -2853,19 +2867,22 @@ a.tc-tiddlylink.tc-plugin-info:hover > .tc-plugin-info-chunk .tc-plugin-info-sta | |||
| color: <<colour foreground>>; | |||
| } | |||
|
|
|||
| .tc-chosen > .tc-tiddlylink:before { | |||
There was a problem hiding this comment.
IMO we need to keep these configuration for backwards compatibility. We can add a "deprecated" comment, but plugin authors may use these styles.
I'll need to make some more tests, with the palette-manager edition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
We get persistent of feedback that the visual aesthetic of TiddlyWiki is old fashioned and dull. It's fair criticism: the default look and feel was intended to be muted so that the users content took centre stage but has ended up flat and lifeless.
The goal of this PR is to allow end users to easily devise their own colour schemes that match their tastes and work harmoniously together. This will be accomplished with a new user interface that is presented in the empty "GettingStarted" tiddler, and in the control panel. The UI would have sliders and switches for the user to express their taste: colourful vs. muted, dark vs. light, saturated vs. unsaturated.
Underneath those controls would be displayed a grid of 9 random palettes generated to match the parameters. The user can choose one of them and either select it, or choose to use it as the basis to generate further variants.
This PR is highly, dangerously experimental. It may well not be merged in this form, but cherry picked into further PRs.
Dynamic Palette Entries
A key idea is being able to set a palette entry to a base colour with modifications, such as lightening, darkening, or increasing saturation. This allows us to define a small number of hard coded colours, with the others being dynamically generated. This approach is inline with the colour system in Android for example. Thus we need a colour manipulation library that we can use for calculating variants of colours. Only color.js met all my requirements (chiefly being able to work with P3 colours and the OKLCH colour space).
Wikify Operator
To resolve the difficulties that we explored in a recent thread on Talk, I have had to include an implementation of a wikify operator. I regard this as quite controversial because while it unlocks some important capabilities, it also invites users to adopt patterns that can be dangerous.
It is also, as expected, inherently slow. Right now this PR slows the style sheet refresh down by a factor of 2 or 3. If we can't resolve this performance regression we will have to explore alternative approaches.
Colour Palette Preview
Something I've wanted for a long time is to improve the colour palette chooser to include a preview. It is not finished yet, but has turned out to be quite easy and very effective:
Progress