Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource Pack Fixes #104

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Resource Pack Fixes #104

wants to merge 13 commits into from

Conversation

A5TR0spud
Copy link
Contributor

@A5TR0spud A5TR0spud commented Apr 17, 2024

Fix effect dimensions
Update non-unique, inconsistent, or otherwise "off" textures
Optimize all textures to reduce file size
Add localization to hardcoded text, allowing resource packs to change them or add support for more languages
(Fixes are added as I am made aware of the offending file)
Fixes #94
I apologize for the messy 10+ commits, I didn't anticipate the scope of this. If you want, I could duplicate these into another branch and open a new PR with just 1 commit.

A5TR0spud and others added 3 commits April 17, 2024 17:14
fix effect dimensions, update some textures i'm not proud of
plating & shell match, dbreath cooldown dimensions increased from 16x16 to 18x18, debacon salt muscle, mana reactor relocation to dragon and consistent coloring with other dragon organs
textures *should* all be visually identical, just smaller in file size
@A5TR0spud A5TR0spud changed the title freshen textures freshen and optimize textures Apr 18, 2024
this time includes all texture files, not just items
again, *SHOULD* be visually IDENTICAL
any "missing" files are intentional, as the "compressed" version was actually larger in file size
@A5TR0spud A5TR0spud changed the title freshen and optimize textures freshen resource pack and optimize textures Apr 18, 2024
A5TR0spud and others added 4 commits April 18, 2024 09:57
*should* work but again i cant test changes to code with my current setup
again again, cant test changes to code, but should work
@A5TR0spud A5TR0spud changed the title freshen resource pack and optimize textures freshen and optimize textures, localize hardcoded text Apr 19, 2024
again again again, i CANNOT test changes to code currently, or even 100% properly bug check, but it *should* work
duplicates vanilla shulker box ui and uses that instead, so texture packs can isolate shulker boxes and chest cavities
AGAIN, I CANNOT CHECK THIS AS OF YET, BUT I DO THINK IT WORKS
yo how long was this using the animal muscle texture? how did i not notice?
@A5TR0spud A5TR0spud changed the title freshen and optimize textures, localize hardcoded text Default Resource Pack Fixes Apr 20, 2024
@A5TR0spud A5TR0spud changed the title Default Resource Pack Fixes Resource Pack Fixes Apr 22, 2024
anotha one (i missed somehow)
arrow dodgin, buff purging, crystalsynthesis, hydrophobia, impact resistance, kb resistance, launching, withered, photosynthesis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add the messages for failing to open a chest cavity into lang files
1 participant