-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resource Pack Fixes #104
Open
A5TR0spud
wants to merge
13
commits into
Tigereye504:master
Choose a base branch
from
A5TR0spud:textures
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Resource Pack Fixes #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix effect dimensions, update some textures i'm not proud of
plating & shell match, dbreath cooldown dimensions increased from 16x16 to 18x18, debacon salt muscle, mana reactor relocation to dragon and consistent coloring with other dragon organs
textures *should* all be visually identical, just smaller in file size
this time includes all texture files, not just items again, *SHOULD* be visually IDENTICAL any "missing" files are intentional, as the "compressed" version was actually larger in file size
*should* work but again i cant test changes to code with my current setup
again again, cant test changes to code, but should work
again again again, i CANNOT test changes to code currently, or even 100% properly bug check, but it *should* work
duplicates vanilla shulker box ui and uses that instead, so texture packs can isolate shulker boxes and chest cavities AGAIN, I CANNOT CHECK THIS AS OF YET, BUT I DO THINK IT WORKS
yo how long was this using the animal muscle texture? how did i not notice?
anotha one (i missed somehow)
arrow dodgin, buff purging, crystalsynthesis, hydrophobia, impact resistance, kb resistance, launching, withered, photosynthesis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix effect dimensions
Update non-unique, inconsistent, or otherwise "off" textures
Optimize all textures to reduce file size
Add localization to hardcoded text, allowing resource packs to change them or add support for more languages
(Fixes are added as I am made aware of the offending file)
Fixes #94
I apologize for the messy 10+ commits, I didn't anticipate the scope of this. If you want, I could duplicate these into another branch and open a new PR with just 1 commit.