Add InsertNewlineAtEOF: true to .clang-format (#4681)

This is a new option to always insert newlines when formatting C++
source files. This is new as of clang-format 16 which we always include.

---
TYPE: NO_HISTORY
DESC: Add InsertNewlineAtEOF: true to .clang-format

.clang-format

@@ -64,6 +64,7 @@ IndentCaseLabels: true
 IndentRequiresClause: true
 IndentWidth:     2
 IndentWrappedFunctionNames: false
+InsertNewlineAtEOF: true
 JavaScriptQuotes: Leave
 JavaScriptWrapImports: true
 KeepEmptyLinesAtTheStartOfBlocks: false

examples/c_api/query_condition_sparse.c

@@ -361,4 +361,4 @@ int main() {
   tiledb_ctx_free(&ctx);
 
   return 0;
-}
+}

examples/cpp_api/query_condition_sparse.cc

@@ -289,4 +289,4 @@ int main() {
     vfs.remove_dir(array_name);
 
   return 0;
-}
+}

experimental/test/compile_experimental_main.cc

@@ -28,4 +28,4 @@
 
 int main() {
   return 0;
-}
+}

experimental/tiledb/common/dag/edge/test/unit_block_edge.cc

@@ -41,4 +41,4 @@
  */
 TEST_CASE("BlockEdge: Trivial test", "[block_edge]") {
   CHECK(true);
-}
+}

experimental/tiledb/common/dag/execution/test/unit_duffs.h

@@ -31,4 +31,4 @@
 #ifndef TILEDB_UNIT_DUFFS_H
 #define TILEDB_UNIT_DUFFS_H
 #include <test/support/tdb_catch.h>
-#endif  // TILEDB_UNIT_DUFFS_H
+#endif  // TILEDB_UNIT_DUFFS_H

experimental/tiledb/common/dag/nodes/test/unit_segmented_mimo_nodes.cc

@@ -1103,4 +1103,4 @@ TEMPLATE_TEST_CASE(
 
 // Repeat one of the tests above but with stop token
 
-#endif
+#endif

test/regression/targets/sc-18836.cc

@@ -116,4 +116,4 @@ TEST_CASE(
 
   if (vfs.is_dir(array_name))
     vfs.remove_dir(array_name);
-}
+}

test/src/cpp-integration-query-condition.cc

@@ -2640,4 +2640,4 @@ TEST_CASE(
   if (vfs.is_dir(array_name)) {
     vfs.remove_dir(array_name);
   }
-}
+}

test/src/test-capi-consolidation-plan.cc

@@ -255,4 +255,4 @@ TEST_CASE_METHOD(
 
   tiledb_consolidation_plan_free_json_str(&str);
   tiledb_consolidation_plan_free(&consolidation_plan);
-}
+}

test/src/test-cppapi-aggregates.cc

@@ -2663,4 +2663,4 @@ TEST_CASE_METHOD(
   CHECK_THROWS(
       QueryExperimental::create_unary_aggregate<SumOperator>(query, "a1"));
   CHECK_THROWS(default_channel.apply_aggregate("Something", operation));
-}
+}

test/src/unit-capi-consolidation.cc

@@ -7243,4 +7243,4 @@ TEST_CASE_METHOD(
   check_commits_dir_sparse(1, 0, 1);
 
   remove_sparse_array();
-}
+}

test/src/unit-capi-fragment_info.cc

@@ -2180,4 +2180,4 @@ TEST_CASE(
   tiledb_vfs_free(&vfs);
   tiledb_error_free(&error);
   tiledb_config_free(&config);
-}
+}

test/src/unit-capi-partial-attribute-write.cc

@@ -284,4 +284,4 @@ TEST_CASE_METHOD(
   CHECK(dim2 == std::vector<uint64_t>({1, 2, 4, 3, 1, 2, 3, 4}));
 
   remove_array();
-}
+}

test/src/unit-cppapi-array.cc

@@ -2203,4 +2203,4 @@ TEST_CASE(
   }
 
   CHECK(i > 0);
-}
+}

test/src/unit-cppapi-datetimes.cc

@@ -142,4 +142,4 @@ TEST_CASE("C++ API: Datetime dimension", "[cppapi][datetime]") {
 
   if (vfs.is_dir(array_name))
     vfs.remove_dir(array_name);
-}
+}

test/src/unit-cppapi-partial-attribute-write.cc

@@ -503,4 +503,4 @@ TEST_CASE_METHOD(
   CHECK(dim2 == std::vector<uint64_t>({0, 0, 0, 0, 0, 0, 0, 0}));
 
   remove_array();
-}
+}

test/src/unit-cppapi-schema.cc

@@ -367,4 +367,4 @@ TEST_CASE(
     CHECK_NOTHROW(tiledb::Dimension::create(
         ctx, "d1", TILEDB_UINT64, domain, &tile_extent));
   }
-}
+}

test/src/unit-cppapi-time.cc

@@ -163,4 +163,4 @@ TEST_CASE("C++ API: Time dimension", "[cppapi][time]") {
     if (vfs.is_dir(array_name))
       vfs.remove_dir(array_name);
   }
-}
+}

test/src/unit-cppapi-update-queries.cc

@@ -310,4 +310,4 @@ TEST_CASE_METHOD(
   check_update_conditions({qc, qc2}, {uvs, uvs2}, 4, encrypt);
 
   remove_sparse_array();
-}
+}

test/src/unit-ctx.cc

@@ -95,4 +95,4 @@ TEST_CASE("C++ API: Test context tags", "[cppapi][ctx-tags]") {
   REQUIRE_NOTHROW(ctx.set_tag("tag1", "value3"));
   REQUIRE(sm->tags().size() == 4);
   REQUIRE(sm->tags().at("tag1") == "value3");
-}
+}

test/src/unit-dense-reader.cc

@@ -1422,4 +1422,4 @@ TEST_CASE_METHOD(
   CHECK(!std::memcmp(c_data_b, data_r_b, c_data_b_size));
   CHECK(offsets_r_b_size == c_offsets_b_size);
   CHECK(!std::memcmp(c_offsets_b, offsets_r_b, c_offsets_b_size));
-}
+}

test/src/unit-duplicates.cc

@@ -730,4 +730,4 @@ TEST_CASE_METHOD(
   CHECK(rc == TILEDB_OK);
   tiledb_array_free(&array);
   tiledb_query_free(&query);
-}
+}

test/src/unit-result-coords.cc

@@ -263,4 +263,4 @@ TEST_CASE_METHOD(
   REQUIRE(rc2.advance_to_next_cell() == true);
   REQUIRE(rc2.pos_ == 2);
   REQUIRE(rc2.advance_to_next_cell() == false);
-}
+}

test/src/unit-result-tile.cc

@@ -424,4 +424,4 @@ TEST_CASE_METHOD(
       num_cells);
 
   CHECK(memcmp(result_count.data(), exp_result_count.data(), num_cells) == 0);
-}
+}

test/src/unit-sparse-global-order-reader.cc

@@ -1588,4 +1588,4 @@ TEST_CASE_METHOD(
   CHECK(rc == TILEDB_OK);
   tiledb_array_free(&array);
   tiledb_query_free(&query);
-}
+}

test/src/unit-tile-metadata.cc

@@ -1652,4 +1652,4 @@ TEST_CASE_METHOD(
   create_array();
   write_fragment();
   check_metadata();
-}
+}

tiledb/api/c_api/config/config_api.cc

@@ -303,4 +303,4 @@ CAPI_INTERFACE(
     tiledb_error_t** error) {
   return api_entry_error<tiledb::api::tiledb_config_iter_done>(
       error, config_iter, done);
-}
+}

tiledb/api/c_api/domain/domain_api_external.h

@@ -231,4 +231,4 @@ TILEDB_EXPORT int32_t tiledb_domain_dump(
 }
 #endif
 
-#endif
+#endif

tiledb/api/c_api/domain/domain_api_internal.h

@@ -126,4 +126,4 @@ inline void ensure_domain_is_valid(const tiledb_domain_handle_t* h) {
   ensure_handle_is_valid(h);
 }
 
-#endif
+#endif

tiledb/api/c_api/vfs/vfs_api_experimental.h

@@ -99,4 +99,4 @@ TILEDB_EXPORT capi_return_t tiledb_vfs_ls_recursive(
 }
 #endif
 
-#endif  // TILEDB_VFS_API_EXPERIMENTAL_H
+#endif  // TILEDB_VFS_API_EXPERIMENTAL_H

tiledb/api/c_api/vfs/vfs_api_external.h

@@ -660,4 +660,4 @@ TILEDB_EXPORT capi_return_t tiledb_vfs_touch(
 }
 #endif
 
-#endif  // TILEDB_CAPI_VFS_EXTERNAL_H
+#endif  // TILEDB_CAPI_VFS_EXTERNAL_H

tiledb/api/c_api_support/argument_validation.h

@@ -75,4 +75,4 @@ inline void ensure_output_pointer_is_valid(void* p) {
 
 }  // namespace tiledb::api
 
-#endif  // TILEDB_CAPI_SUPPORT_ARGUMENT_VALIDATION_H
+#endif  // TILEDB_CAPI_SUPPORT_ARGUMENT_VALIDATION_H

tiledb/api/c_api_support/c_api_support.h

@@ -43,4 +43,4 @@
 #include "capi_function_override.h"
 #endif
 
-#endif  // TILEDB_CAPI_SUPPORT_H
+#endif  // TILEDB_CAPI_SUPPORT_H

tiledb/api/c_api_support/exception_wrapper/exception_wrapper.cc

@@ -91,4 +91,4 @@ void ETVisitorStdException::item(const std::exception& e) noexcept {
   }
 }
 
-}  // namespace tiledb::api::detail
+}  // namespace tiledb::api::detail

tiledb/api/c_api_support/exception_wrapper/test/compile_exception_wrapper_main.cc

@@ -33,4 +33,4 @@ int main() {
   tiledb::api::detail::ETVisitorStdException v{};
   x.visit(v);
   return 1;
-}
+}

tiledb/api/c_api_support/handle/handle.cc

@@ -30,4 +30,4 @@
 
 #include "handle.h"
 
-namespace tiledb::api {}  // namespace tiledb::api
+namespace tiledb::api {}  // namespace tiledb::api

tiledb/api/c_api_test_support/storage_manager_stub/storage_manager_stub.cc

@@ -28,4 +28,4 @@
  * @section DESCRIPTION
  *
  * This file has definitions for `class StorageManagerStub`.
- */
+ */

tiledb/common/interval/interval.cc

@@ -32,4 +32,4 @@
 
 #include "interval.h"
 
-namespace tiledb::common::detail {}  // namespace tiledb::common::detail
+namespace tiledb::common::detail {}  // namespace tiledb::common::detail

tiledb/common/random/random_label.cc

@@ -60,4 +60,4 @@ std::string random_label() {
   return ss.str();
 }
 
-}  // namespace tiledb::common
+}  // namespace tiledb::common

tiledb/common/stdx_string.cc

@@ -54,4 +54,4 @@ size_t common_prefix_size(
   return size;
 }
 
-}  // namespace tiledb::stdx::string
+}  // namespace tiledb::stdx::string

tiledb/common/thread_pool/test/compile_thread_pool_main.cc

@@ -31,4 +31,4 @@
 int main() {
   (void)sizeof(tiledb::common::ThreadPool);
   return 0;
-}
+}

tiledb/common/types/test/compile_datum_main.cc

@@ -33,4 +33,4 @@ int main() {
   (void)sizeof(tiledb::common::UntypedDatumView);
   (void)sizeof(tiledb::common::DynamicTypedDatumView);
   return 0;
-}
+}

tiledb/platform/platform.h

@@ -50,4 +50,4 @@ constexpr bool is_os_linux = true;
 #endif  // _WIN32
 
 }  // namespace tiledb::platform
-#endif  // TILEDB_PLATFORM_H
+#endif  // TILEDB_PLATFORM_H

tiledb/sm/array/test/compile_array_main.cc

@@ -31,4 +31,4 @@
 int main() {
   (void)sizeof(tiledb::sm::ArrayDirectory);
   return 0;
-}
+}

tiledb/sm/array_schema/test/compile_attribute_main.cc

@@ -31,4 +31,4 @@
 int main() {
   (void)sizeof(tiledb::sm::Attribute);
   return 0;
-}
+}

tiledb/sm/array_schema/test/compile_dimension_main.cc

@@ -31,4 +31,4 @@
 int main() {
   (void)sizeof(tiledb::sm::Dimension);
   return 0;
-}
+}

tiledb/sm/array_schema/test/compile_domain_main.cc

@@ -31,4 +31,4 @@
 int main() {
   (void)sizeof(tiledb::sm::Domain);
   return 0;
-}
+}

tiledb/sm/array_schema/test/unit_dimension.cc

@@ -438,4 +438,4 @@ TEST_CASE("Dimension::oob format") {
       error ==
       "Coordinate -682.75 is out of domain bounds [-682.73999, 929.42999] on "
       "dimension 'X'");
-}
+}

tiledb/sm/buffer/test/compile_buffer_list_main.cc

@@ -32,4 +32,4 @@
 int main() {
   tiledb::sm::BufferList();
   return 0;
-}
+}

tiledb/sm/buffer/test/compile_buffer_main.cc

@@ -31,4 +31,4 @@
 int main() {
   tiledb::sm::Buffer();
   return 0;
-}
+}

tiledb/sm/c_api/api_argument_validator.h

@@ -171,4 +171,4 @@ inline int32_t sanity_check(
     return save_error(ctx, _s);                                            \
   }()
 
-#endif  // TILEDB_CAPI_HELPERS_H
+#endif  // TILEDB_CAPI_HELPERS_H

tiledb/sm/compressors/test/compile_compressors_main.cc

@@ -43,4 +43,4 @@ int main() {
   (void)sizeof(tiledb::sm::RLE);
   (void)sizeof(tiledb::sm::ZStd);
   return 0;
-}
+}

tiledb/sm/compressors/test/unit_delta_compressor.cc

@@ -97,4 +97,4 @@ TEST_CASE("Test delta decompression of a vector", "[decompression][delta]") {
 
   std::vector<int64_t> expected{0, 1, 1, 15, 3, 0, 2, 7, 1};
   CHECK(uncompressed == expected);
-}
+}

tiledb/sm/compressors/test/unit_dict_compressor.cc

@@ -429,4 +429,4 @@ TEST_CASE(
   for (uint32_t i = 0; i < expected_offsets.size(); i++) {
     CHECK(expected_offsets[i] == decompressed_offsets[i]);
   }
-}
+}

tiledb/sm/config/test/compile_config_main.cc

@@ -31,4 +31,4 @@
 int main() {
   (void)sizeof(tiledb::sm::Config);
   return 0;
-}
+}

tiledb/sm/cpp_api/vfs_experimental.h

@@ -202,4 +202,4 @@ class VFSExperimental {
 };
 }  // namespace tiledb
 
-#endif  // TILEDB_VFS_EXPERIMENTAL_H
+#endif  // TILEDB_VFS_EXPERIMENTAL_H