Improve UIView Auto Layout tests (#337)

* Improve `UIView` Auto Layout tests * Add local variable to DRY implementation * Add non-zero dimensions * Use consistent formatting
Tinder · Feb 13, 2024 · 5ef2f1f · 5ef2f1f
1 parent 9d33ee2
commit 5ef2f1f
Show file tree

Hide file tree

Showing 2 changed files with 426 additions and 173 deletions.
diff --git a/Tests/LayoutTests/Support/NimbleMatchers.swift b/Tests/LayoutTests/Support/NimbleMatchers.swift
@@ -28,15 +28,19 @@ extension XCTestCase {
     // swiftlint:disable cyclomatic_complexity
 
     @MainActor
-    internal func match(_ expectedConstraint: NSLayoutConstraint) -> Matcher<NSLayoutConstraint> {
+    internal func match(
+        _ expectedConstraint: NSLayoutConstraint,
+        isActive: Bool? = nil // swiftlint:disable:this discouraged_optional_boolean
+    ) -> Matcher<NSLayoutConstraint> {
         // swiftlint:disable:next closure_body_length
         Matcher { expression in
             guard let constraint: NSLayoutConstraint = try expression.evaluate()
             else { return MatcherResult(status: .fail, message: .expectedTo("not be nil, got <nil>")) }
-            guard constraint.isActive == expectedConstraint.isActive
+            let isActiveExpected: Bool = isActive ?? expectedConstraint.isActive
+            guard constraint.isActive == isActiveExpected
             else {
                 let message: String = """
-                    match `isActive` <\(expectedConstraint.isActive)>, \
+                    match `isActive` <\(isActiveExpected)>, \
                     got <\(constraint.isActive)>
                     """
                 return MatcherResult(status: .fail, message: .expectedTo(message))