Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move extension to NSLayoutYAxisAnchor.swift #175

Merged
merged 3 commits into from
Oct 31, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions Sources/Layout/LayoutAnchoring.swift
Original file line number Diff line number Diff line change
Expand Up @@ -45,27 +45,3 @@ extension UILayoutGuide: LayoutBoundary, LayoutCenter, LayoutSize {
public var width: NSLayoutDimension { widthAnchor }
public var height: NSLayoutDimension { heightAnchor }
}

// swiftlint:disable function_default_parameter_at_end

extension NSLayoutYAxisAnchor {

public func constraint(
is relation: NSLayoutConstraint.Relation = .equal,
to anchor: NSLayoutYAxisAnchor,
constant: CGFloat = 0
) -> NSLayoutConstraint {
switch relation {
case .equal:
return constraint(equalTo: anchor, constant: constant)
case .greaterThanOrEqual:
return constraint(greaterThanOrEqualTo: anchor, constant: constant)
case .lessThanOrEqual:
return constraint(lessThanOrEqualTo: anchor, constant: constant)
@unknown default:
return constraint(equalTo: anchor, constant: constant)
}
}
}

// swiftlint:enable function_default_parameter_at_end
34 changes: 34 additions & 0 deletions Sources/Layout/NSLayoutYAxisAnchor.swift
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
//
// All Contributions by Match Group
//
// Copyright © 2023 Tinder (Match Group, LLC)
//
// Licensed under the Match Group Modified 3-Clause BSD License.
// See https://github.com/Tinder/Layout/blob/main/LICENSE for license information.
//

import UIKit

extension NSLayoutYAxisAnchor {

// swiftlint:disable function_default_parameter_at_end

public func constraint(
is relation: NSLayoutConstraint.Relation = .equal,
to anchor: NSLayoutYAxisAnchor,
constant: CGFloat = 0
) -> NSLayoutConstraint {
switch relation {
case .equal:
return constraint(equalTo: anchor, constant: constant)
case .greaterThanOrEqual:
return constraint(greaterThanOrEqualTo: anchor, constant: constant)
case .lessThanOrEqual:
return constraint(lessThanOrEqualTo: anchor, constant: constant)
@unknown default:
return constraint(equalTo: anchor, constant: constant)
}
}

// swiftlint:enable function_default_parameter_at_end
}
84 changes: 0 additions & 84 deletions Tests/LayoutTests/LayoutAnchoringTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -142,90 +142,6 @@ final class LayoutAnchoringTests: XCTestCase {
expect(layoutSupport.height) == view.height
}

func testConstraintToYAnchor_withDefaults() {

// GIVEN

let viewA: UIView = .init()
let viewB: UIView = .init()
let expected: NSLayoutConstraint = viewA
.centerY
.constraint(equalTo: viewB.centerY)

// WHEN

let constraint: NSLayoutConstraint = viewA
.centerY
.constraint(to: viewB.centerY)

// THEN

expect(constraint).to(match(expected))
}

func testConstraintToYAnchor_withConstant() {

// GIVEN

let viewA: UIView = .init()
let viewB: UIView = .init()
let expected: NSLayoutConstraint = viewA
.centerY
.constraint(equalTo: viewB.centerY, constant: 50)

// WHEN

let constraint: NSLayoutConstraint = viewA
.centerY
.constraint(is: .equal, to: viewB.centerY, constant: 50)

// THEN

expect(constraint).to(match(expected))
}

func testConstraintToYAnchor_withGreaterThanOrEqualRelation() {

// GIVEN

let viewA: UIView = .init()
let viewB: UIView = .init()
let expected: NSLayoutConstraint = viewA
.centerY
.constraint(greaterThanOrEqualTo: viewB.centerY)

// WHEN

let constraint: NSLayoutConstraint = viewA
.centerY
.constraint(is: .greaterThanOrEqual, to: viewB.centerY)

// THEN

expect(constraint).to(match(expected))
}

func testConstraintToYAnchor_withLessThanOrEqualRelation() {

// GIVEN

let viewA: UIView = .init()
let viewB: UIView = .init()
let expected: NSLayoutConstraint = viewA
.centerY
.constraint(lessThanOrEqualTo: viewB.centerY)

// WHEN

let constraint: NSLayoutConstraint = viewA
.centerY
.constraint(is: .lessThanOrEqual, to: viewB.centerY)

// THEN

expect(constraint).to(match(expected))
}

func testConstraintToLayoutDimension_withDefaults() {

// GIVEN
Expand Down
100 changes: 100 additions & 0 deletions Tests/LayoutTests/NSLayoutYAxisAnchorTests.swift
Original file line number Diff line number Diff line change
@@ -0,0 +1,100 @@
//
// All Contributions by Match Group
//
// Copyright © 2023 Tinder (Match Group, LLC)
//
// Licensed under the Match Group Modified 3-Clause BSD License.
// See https://github.com/Tinder/Layout/blob/main/LICENSE for license information.
//

@testable import Layout
import Nimble
import XCTest

@MainActor
final class NSLayoutYAxisAnchorTests: XCTestCase {

func testConstraintToYAnchor_withDefaults() {

// GIVEN

let viewA: UIView = .init()
let viewB: UIView = .init()
let expected: NSLayoutConstraint = viewA
.centerY
.constraint(equalTo: viewB.centerY)

// WHEN

let constraint: NSLayoutConstraint = viewA
.centerY
.constraint(to: viewB.centerY)

// THEN

expect(constraint).to(match(expected))
}

func testConstraintToYAnchor_withConstant() {

// GIVEN

let viewA: UIView = .init()
let viewB: UIView = .init()
let expected: NSLayoutConstraint = viewA
.centerY
.constraint(equalTo: viewB.centerY, constant: 50)

// WHEN

let constraint: NSLayoutConstraint = viewA
.centerY
.constraint(is: .equal, to: viewB.centerY, constant: 50)

// THEN

expect(constraint).to(match(expected))
}

func testConstraintToYAnchor_withGreaterThanOrEqualRelation() {

// GIVEN

let viewA: UIView = .init()
let viewB: UIView = .init()
let expected: NSLayoutConstraint = viewA
.centerY
.constraint(greaterThanOrEqualTo: viewB.centerY)

// WHEN

let constraint: NSLayoutConstraint = viewA
.centerY
.constraint(is: .greaterThanOrEqual, to: viewB.centerY)

// THEN

expect(constraint).to(match(expected))
}

func testConstraintToYAnchor_withLessThanOrEqualRelation() {

// GIVEN

let viewA: UIView = .init()
let viewB: UIView = .init()
let expected: NSLayoutConstraint = viewA
.centerY
.constraint(lessThanOrEqualTo: viewB.centerY)

// WHEN

let constraint: NSLayoutConstraint = viewA
.centerY
.constraint(is: .lessThanOrEqual, to: viewB.centerY)

// THEN

expect(constraint).to(match(expected))
}
}