Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for default parameters #240

Merged
merged 10 commits into from
Nov 29, 2023
Merged

Conversation

tinder-emanharoutunian
Copy link
Collaborator

@tinder-emanharoutunian tinder-emanharoutunian commented Nov 14, 2023

This PR tests for additional parameters that were previously not explicitly covered, namely the testing of default parameters such as priority and relation for Layout and LayoutItem APIs.

Update Dec 1, 2023:
We had missed testing one snapshot's default parameters. This was corrected in this PR

@tinder-emanharoutunian tinder-emanharoutunian marked this pull request as ready for review November 14, 2023 23:54
Tests/LayoutTests/UIView+AutoLayoutTests.swift Outdated Show resolved Hide resolved
Tests/LayoutTests/UIView+AutoLayoutTests.swift Outdated Show resolved Hide resolved
Tests/LayoutTests/UIView+AutoLayoutTests.swift Outdated Show resolved Hide resolved
Tests/LayoutTests/UIView+AutoLayoutTests.swift Outdated Show resolved Hide resolved
Tests/LayoutTests/UIView+AutoLayoutTests.swift Outdated Show resolved Hide resolved
Tests/LayoutTests/UIView+AutoLayoutTests.swift Outdated Show resolved Hide resolved
tinder-cfuller
tinder-cfuller previously approved these changes Nov 29, 2023
Base automatically changed from snapshot-adjustments to main November 29, 2023 19:30
@tinder-emanharoutunian tinder-emanharoutunian dismissed tinder-cfuller’s stale review November 29, 2023 19:30

The base branch was changed.

@tinder-emanharoutunian tinder-emanharoutunian enabled auto-merge (squash) November 29, 2023 19:38
@tinder-emanharoutunian tinder-emanharoutunian merged commit e46f329 into main Nov 29, 2023
2 checks passed
@tinder-emanharoutunian tinder-emanharoutunian deleted the add-tests-modifications branch November 29, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants