Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize files #246

Merged
merged 6 commits into from
Dec 7, 2023
Merged

Reorganize files #246

merged 6 commits into from
Dec 7, 2023

Conversation

tinder-emanharoutunian
Copy link
Collaborator

@tinder-emanharoutunian tinder-emanharoutunian commented Dec 6, 2023

This PR reorganizes the paths of all source and test files in Layout. It also moves code from UIView+Frames to a new dedicated file UIView-AutoresizingMask.swift. The tests were moved to match as well.

@tinder-emanharoutunian tinder-emanharoutunian marked this pull request as ready for review December 6, 2023 21:57
@tinder-garricnahapetian
Copy link
Contributor

Can we do the UIView-AutoresizingMask.swift move in a separate PR? We must have missed that when we did all of the other moves. Does anything else need to be moved?

@tinder-emanharoutunian tinder-emanharoutunian self-assigned this Dec 6, 2023
# Conflicts:
#	Sources/Layout/UIKit/UIView+NSLayoutAnchor.swift
#	Sources/Layout/UIView+LayoutAnchor.swift
#	Sources/Layout/UIView+NSLayoutAnchor.swift
#	Tests/LayoutTests/LayoutAnchoringTests.swift
#	Tests/LayoutTests/UIKit/UIView+FramesTests.swift
#	Tests/LayoutTests/UIKit/UIView+NSLayoutAnchorTests.swift
#	Tests/LayoutTests/UIKit/UIViewControllerTests.swift
#	Tests/LayoutTests/UIView+LayoutAnchorTests.swift
#	Tests/LayoutTests/UIView+NSLayoutAnchorTests.swift
#	Tests/LayoutTests/UIViewControllerTests.swift
@tinder-emanharoutunian
Copy link
Collaborator Author

Can we do the UIView-AutoresizingMask.swift move in a separate PR? We must have missed that when we did all of the other moves. Does anything else need to be moved?

Resolved with: #247

tinder-cfuller
tinder-cfuller previously approved these changes Dec 7, 2023
Copy link
Collaborator

@tinder-cfuller tinder-cfuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@tinder-emanharoutunian tinder-emanharoutunian merged commit 7a9876f into main Dec 7, 2023
2 checks passed
@tinder-emanharoutunian tinder-emanharoutunian deleted the reorganize-files branch December 7, 2023 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants