Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove no longer accurate comment #254

Merged

Conversation

honnix
Copy link
Contributor

@honnix honnix commented Nov 4, 2024

The said starlark function doesn't seem to filters out source targets. Maybe something has changed on Bazel side since the code was added.

It probably shouldn't do that in the first place anyway because those are needed to compute source digests, as I understood. Is that correct @tinder-maxwellelliott ?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@tinder-maxwellelliott tinder-maxwellelliott merged commit 5d82722 into Tinder:master Nov 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants