fix: Correctly handle repo name when apply fine grained filtering

[honnix]

When using --useCquery or setting --bazelCommandOptions=--consistent_labels (while not using --useCquery), canonical repo name must be used for --fineGrainedHashExternalRepos, but with a leading @. In that case, we cannot remove all @ from source target name, otherwise nothing will never match --fineGrainedHashExternalRepos.

This PR fixes that by asking users to always provide apparent or canonical repo name (with @ or @@).

After this fix, it is not strictly necessary to use canonical name when --useCquery because we compare repo name without any @, but to keep it easier for users to follow, the readme says otherwise.

Note that this is a breaking change.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[honnix]

@tinder-maxwellelliott I'm thinking maybe it's better not to do this dance, but instead asking users to provide either apparent or canonical repo names with all the necessary @s. That would be a breaking change for sure, but I think that would make things a bit easier to handle and understand. What do you think?

[honnix]

bazel run format did this.

[tinder-maxwellelliott]

@tinder-maxwellelliott I'm thinking maybe it's better not to do this dance, but instead asking users to provide either apparent or canonical repo names with all the necessary @s. That would be a breaking change for sure, but I think that would make things a bit easier to handle and understand. What do you think?

I think that sounds good to me, I am wary of any all-targets querying in bzlmod anyhow

[honnix]

@tinder-maxwellelliott I'm thinking maybe it's better not to do this dance, but instead asking users to provide either apparent or canonical repo names with all the necessary @s. That would be a breaking change for sure, but I think that would make things a bit easier to handle and understand. What do you think?

I think that sounds good to me, I am wary of any all-targets querying in bzlmod anyhow

Cool. I will rework this PR a bit then.