[AD-75] Extend the LDAP bundle #18
Conversation
Modify configuration to only contain the specific configurations for this bundle Modify configuration bean info to contain configurations from both this bundle, and the LDAP bundle Extend most classes with their LDAP bundle counterparts - removing duplicate code Extend functionality for AnyObjects Add some configuration messages
|
@Sylinsic now that Tirasa/ConnIdLDAPBundle#26 is merged, please include the change to update ldap connector version to |
@ilgrosso updated. I didn't commit it originally as I didn't want to push reliance on a snapshot version to the main repo |
I see there are several test failures now that workflows could run, not possible until LDAP version was updated. |
I believe these should all run successfully now |
|
@Sylinsic the build is green again, good. |
Fix any object filter parentheses
|
@Sylinsic I see you keep committing on this PR: does this mean that it's not ready to be reviewed and merged? |
AD doesn't utilise the ';binary' on binary attributes, which prevents them from being pulled in.
I believe it is, however I just stumbled upon two issues when actually using the snapshot bundle, and as this hadn't been merged yet I figured I may as well whack them into this PR instead of open another |
|
@Sylinsic after careful evaluation by @fmartelli we decided that this PR contains some breaking changes that cannot be merged for maintenance release 1.3.10. |
Currently, the AD bundle repeats quite a bit of code, and only in some places inherits from the LDAP bundle.
As AD is fundamentally communicated with via LDAP, the AD bundle should inherit most of it’s functionality from the LDAP bundle, therefore inheriting LDAP capabilities, and just extending classes/overriding methods where necessary.
This issue is for part 2 of sorting this - the extension of the AD bundle
N.B. This pull request is reliant on version 1.5.9 of the LDAP bundle being released; this code won't compile until the counterpart code is available for usage.
Merging of Tirasa/ConnIdLDAPBundle#26 is required.