Fix compiler warnings from extensions #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One uses the `wkt` property, and one uses `to_wkt`, but the former calls the latter, so these implementations are pretty much the same.
- The callers of `gdal_open_vector` all pass in `const char*`, and so do all uses of the argument in this function. - `GDALGetMetadataItem` returns `const char *`, so fix the corresponding variable type. - `CPLCheckForFile` takes a `char*`, because it might modify its input, so we need to convert bytes to `char*` instead of `const char*`.
sgillies
approved these changes
Dec 3, 2023
|
@sgillies note to port to maint-1.9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fixes 3 sets of warnings:
__hash__function, caused by a duplicated definition on the Cython side.const char*->char*warnings.See commit message for details.