Rename project to lowercase "rtree" #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames the project name from "Rtree" to "rtree", which resolves tools that assume lowercase names. Just looking at the build tools like setuptools and cibuildwheel, I'm noticing that they are less forgiving for projects with mixed-case project names.
For example, I've looked over the PyPI archives, up to version 0.8.3 (Dec 15, 2016) the sdist and bdist files are consistently
Rtree*. However, since version 0.9.1 (Nov 26, 2019) the files are eitherRtree-*.tar.gzsdist orrtree-*.whlbdist files. And now recent cibuildwheel and/or auditwheel tools assume lowercase projects, and don't work anymore (#349).This change would make sdist and bdist files (e.g. for PyPI) consistently
rtree-*{.whl|.tar.gz}, and the included bdist libraries for Linux would be inrtree.libs. It should also fix recent issues with cibuildwheel and/or auditwheel.