TokenVault: Implementing full EIP-20 support and improved tests #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we had a check for isToken() interface function. The check is important for testing if the token is correct. However, not all of the EIP-20 tokens support such a check. Therefore, modified the check to check totalSupply instead. 0 supply is permitted, for example the token could be minted afterwards. Also, there were no tests for this check, added those.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had a check for isToken() interface function.
The check is important for testing if the token is correct.
However, not all of the EIP-20 tokens support such a check.
Therefore, modified the check to check totalSupply instead.
0 supply is permitted, for example the token could be minted afterwards.
Also, there were no tests for this check, added those.
pragma_for_bitcoincash.pdf