Link Terrain3D object when creating UndoRedo action to mark scene as unsaved #508
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokisanGames
reviewed
Oct 4, 2024
src/terrain_3d_editor.cpp
Outdated
| @@ -508,7 +508,7 @@ void Terrain3DEditor::_store_undo() { | |||
| EditorUndoRedoManager *undo_redo = _terrain->get_plugin()->get_undo_redo(); | |||
| String action_name = String("Terrain3D ") + OPNAME[_operation] + String(" ") + TOOLNAME[_tool]; | |||
| LOG(DEBUG, "Creating undo action: '", action_name, "'"); | |||
| undo_redo->create_action(action_name); | |||
| undo_redo->create_action(action_name, UndoRedo::MERGE_DISABLE, get_terrain()); | |||
There was a problem hiding this comment.
You could also just provide _terrain.
But more importantly how does this tell godot to mark scenes as edited? I haven't tried it yet. The docs only say, "If custom_context object is provided, it will be used for deducing target history (instead of using the first operation).".
Is there a PR or some other documentation that shows how custom_context object connects to save status?
There was a problem hiding this comment.
Based off this comment on the PR mentioned before, just gave it a go and the results were desirable:
There was a problem hiding this comment.
Thanks for the link. I filed a doc issue:
godotengine/godot-docs#10043
TokisanGames
changed the title
TokisanGames
force-pushed
the
link-undoredo-to-terrain-object
branch
from
aa76ecc
to
2999179
Compare
|
Great, thank you. |
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #184
This moves the undo/redo history from global to the scene containing the object linked.