Skip to content

Commit

Permalink
Merge branch 'LawnchairLauncher:develop' into develop
Browse files Browse the repository at this point in the history
  • Loading branch information
TolLescnq7 authored Sep 13, 2024
2 parents 5caa14b + bd0a23b commit 63f35c7
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 5 deletions.
6 changes: 1 addition & 5 deletions .github/icon_checklist.md
Original file line number Diff line number Diff line change
@@ -1,26 +1,22 @@
Thanks for your contribution!

While waiting for a review from our team, you can do a self-review to ensure that your icons are suitable for Lawnicons.
We try to do the review within 7 days. While waiting for a review from our team, you can do a self-review to ensure that your icons are suitable for Lawnicons.

### Canvas and sizes
1. Canvas: `192×192px`.
2. Non-square icons: the long side of the icons should be `160px`.
3. Square icons: `154×154px`.
- [ ] Approved by the Lawnicons reviewer
### Color, stroke width and rounding
1. Color: non-transparent black `#000`.
2. No fill. Base stroke width: `12px`. `14px`, `10px`, `8px` — depending on the shape of the icons. `6px` — for fine details.
3. Rounded ends and joins. 90° corners are rounded by `6-32px`.
- [ ] Approved by the Lawnicons reviewer
### Naming
1. Names should match the official app name and contain no additional text.
2. If the first `3` characters of the app name contain letters not from the English alphabet, then add a localized (or transliterated) name via `~~`. Example: `京东 ~~ JD`.
3. The names of the drawables should repeat the names of the apps if nothing prevents it.
- [ ] Approved by the Lawnicons reviewer
### Quality
1. Ensure that icons are easily recognizable.
2. Align icons to [the visual center](https://crazybitsstudios.com/another-way-of-aligning-elements-when-creating-icons) as much as possible within the guidelines. The visual center is where your icon looks and feels centered.
3. Avoid noticable black spots by reducing the stroke width or simplifying the icons.
4. Avoid close distances between strokes. The icons on the phone screen will be smaller, so the small distances between the strokes will stick together.
5. Avoid drastic changes in stroke widths. When the strokes next to each other differ in width by 4px or more, the icon will look sloppy.
- [ ] Approved by the Lawnicons reviewer
4 changes: 4 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ For additional information on designing icons and samples, see [the Lawnicons Fi
Need help? [Join Lawnchair on Discord](https://discord.com/invite/3x8qNWxgGZ).

### TL;DR on icon design

> [!NOTE]
> Upload no more than 10 icons at a time, because reviewers only have time for small pull requests.
The canvas is `192×192px`. The content area for most icons is `160×160px`, meaning the long side of an icon should be `160px`. Square icons should be `154×154px`. No fill, the stroke width is `12px`. All shapes should be black `#000` with rounded ends and joins. Round 90° angles by `6-32px`. Avoid noticable black spots, close distances between strokes, and drastic changes in stroke widths. Simplify details, but don't lose recognizability. Provide original and localized names, so the icons can be found.

To avoid rework, save time and understand the limitations of the guidelines, it is worth reading reviews (e.g., [+8 icons, +1 link, +4 updates](https://github.com/LawnchairLauncher/lawnicons/pull/1865)) and creating 5-10 icons in the first contribution.
Expand Down
3 changes: 3 additions & 0 deletions app/assets/appfilter.xml
Original file line number Diff line number Diff line change
Expand Up @@ -882,6 +882,7 @@
<item component="ComponentInfo{com.bandlab.bandlab/com.bandlab.navigation.entry.NavigationActivity}" drawable="bandlab" name="BandLab" />
<item component="ComponentInfo{com.bandsintown/com.bandsintown.activity.SplashScreen}" drawable="bandsintown" name="Bandsintown" />
<item component="ComponentInfo{com.bandsintown/com.bandsintown.SplashScreen}" drawable="bandsintown" name="Bandsintown" />
<item component="ComponentInfo{com.ada.mbank.mehr/com.ada.mbank.component.SplashActivity}" drawable="bank_mehr" name="بانک مهر ~~ Bank Mehr" />
<item component="ComponentInfo{com.banknorwegian/com.banknorwegian.MainActivity}" drawable="bank_norwegian" name="Bank Norwegian" />
<item component="ComponentInfo{com.infonow.bofa/com.bofa.ecom.marvel.application.Black}" drawable="bank_of_america" name="Bank of America" />
<item component="ComponentInfo{com.infonow.bofa/com.infonow.bofa.StartupActivity}" drawable="bank_of_america" name="Bank of America" />
Expand Down Expand Up @@ -5779,6 +5780,7 @@
<item component="ComponentInfo{org.telegram.mdgram/org.telegram.ui.LaunchActivityBlueIcon}" drawable="mdgram" name="MDGram" />
<item component="ComponentInfo{com.stoik.mdscan/com.stoik.mdscan.MDScanActivity}" drawable="mdscan_ocr" name="MDScan + OCR" />
<item component="ComponentInfo{com.stoik.mdscan/com.stoik.mdscan.MainActivity}" drawable="mdscan_ocr" name="MDScan + OCR" />
<item component="ComponentInfo{com.dawsonsoftware.meadmate/com.dawsonsoftware.meadmate.MainActivity}" drawable="mead_mate" name="Mead Mate" />
<item component="ComponentInfo{gq.kirmanak.mealient/gq.kirmanak.mealient.ui.activity.MainActivity}" drawable="mealient" name="Mealient" />
<item component="ComponentInfo{com.google.tango.measure/com.google.tango.measure.MainActivity}" drawable="measure" name="Measure" />
<item component="ComponentInfo{com.google.tango.measure/com.google.tango.measure.android.LaunchScreenActivity}" drawable="measure" name="Measure" />
Expand Down Expand Up @@ -6872,6 +6874,7 @@
<item component="ComponentInfo{foss.cnugteren.nlweer/foss.cnugteren.nlweer.MainActivity}" drawable="nlweer" name="NLWeer" />
<item component="ComponentInfo{in.mfile/com.nmmedit.files.ui.FileManagerActivity}" drawable="nmm_file_manager" name="NMM File Manager" />
<item component="ComponentInfo{com.bashsoftware.boycott/com.bashsoftware.boycott.MainActivity}" drawable="no_thanks" name="No Thanks" />
<item component="ComponentInfo{market.nobitex/ir.nobitex.activities.SplashScreen}" drawable="nobitex" name="Nobitex" />
<item component="ComponentInfo{com.net.furaffrate.furaffinity/com.net.furaffrate.furaffinity.activity.start.StartActivity}" drawable="noc_for_fur_affinity" name="NOC for Fur Affinity" />
<item component="ComponentInfo{com.net.furaffrate.furaffinity/one.furaffnoc.android.activity.start.StartActivity}" drawable="noc_for_fur_affinity" name="NOC for Fur Affinity" />
<item component="ComponentInfo{com.n00nedev.nofasel/com.n00nedev.nofasel.MainActivity}" drawable="nofasel" name="NoFasel" />
Expand Down
3 changes: 3 additions & 0 deletions svgs/bank_mehr.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions svgs/mead_mate.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions svgs/nobitex.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 63f35c7

Please sign in to comment.