Skip to content

Commit

Permalink
Adjust some parameters on the generic tests
Browse files Browse the repository at this point in the history
  • Loading branch information
Tom-Newton committed Oct 4, 2024
1 parent b9d6ed2 commit e00f8f3
Showing 1 changed file with 13 additions and 5 deletions.
18 changes: 13 additions & 5 deletions cpp/src/arrow/filesystem/azurefs_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -364,9 +364,9 @@ class TestGeneric : public ::testing::Test, public GenericFileSystemTest {
std::shared_ptr<FileSystem> GetEmptyFileSystem() override { return fs_; }

bool have_implicit_directories() const override { return true; }
bool allow_write_file_over_dir() const override { return true; }
bool allow_read_dir_as_file() const override { return true; }
bool allow_move_dir() const override { return false; }
bool allow_write_file_over_dir() const override { return false; }
bool allow_read_dir_as_file() const override { return false; }
bool allow_move_dir() const override { return true; }
bool allow_move_file() const override { return true; }
bool allow_append_to_file() const override { return true; }
bool have_directory_mtimes() const override { return true; }
Expand Down Expand Up @@ -404,8 +404,12 @@ class TestAzuriteGeneric : public TestGeneric {
}

protected:
// Azurite doesn't support moving files over containers.
// Azurite doesn't block writing files over directories.
bool allow_write_file_over_dir() const override { return true; }
// Azurite doesn't support moving files.
bool allow_move_file() const override { return false; }
// Azurite doesn't support moving directories.
bool allow_move_dir() const override { return false; }
// Azurite doesn't support directory mtime.
bool have_directory_mtimes() const override { return false; }
// DeleteDir() doesn't work with Azurite on macOS
Expand All @@ -426,8 +430,12 @@ class TestAzureFlatNSGeneric : public TestGeneric {
}

protected:
// Flat namespace account doesn't support moving files over containers.
// Flat namespace account doesn't block writing files over directories.
bool allow_write_file_over_dir() const override { return true; }
// Flat namespace account doesn't support moving files.
bool allow_move_file() const override { return false; }
// Flat namespace account doesn't support moving directories.
bool allow_move_dir() const override { return false; }
// Flat namespace account doesn't support directory mtime.
bool have_directory_mtimes() const override { return false; }
};
Expand Down

0 comments on commit e00f8f3

Please sign in to comment.