forked from helidon-io/helidon
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Issue helidon-io#7101 - WebClient should have a mode that is resilien…
…t to bad media/content types Signed-off-by: Tomáš Kraus <[email protected]>
- Loading branch information
1 parent
cd0546a
commit 4258027
Showing
7 changed files
with
261 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
147 changes: 147 additions & 0 deletions
147
...tegration/webclient/src/test/java/io/helidon/tests/integration/webclient/HeadersTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,147 @@ | ||
| /* | ||
| * Copyright (c) 2024 Oracle and/or its affiliates. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package io.helidon.tests.integration.webclient; | ||
|
|
||
| import java.util.Optional; | ||
| import java.util.concurrent.CompletionException; | ||
| import java.util.concurrent.ExecutionException; | ||
| import java.util.concurrent.TimeUnit; | ||
| import java.util.concurrent.TimeoutException; | ||
|
|
||
| import io.helidon.common.http.Http; | ||
| import io.helidon.common.http.MediaType; | ||
| import io.helidon.webclient.WebClient; | ||
| import io.helidon.webclient.WebClientResponse; | ||
| import io.helidon.webserver.Routing; | ||
| import io.helidon.webserver.ServerRequest; | ||
| import io.helidon.webserver.ServerResponse; | ||
| import io.helidon.webserver.WebServer; | ||
|
|
||
| import org.junit.jupiter.api.AfterAll; | ||
| import org.junit.jupiter.api.BeforeAll; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import static org.hamcrest.CoreMatchers.containsString; | ||
| import static org.hamcrest.CoreMatchers.instanceOf; | ||
| import static org.hamcrest.CoreMatchers.is; | ||
| import static org.hamcrest.CoreMatchers.notNullValue; | ||
| import static org.hamcrest.MatcherAssert.assertThat; | ||
| import static org.junit.jupiter.api.Assertions.fail; | ||
|
|
||
| public class HeadersTest { | ||
|
|
||
| private static final String INVALID_CONTENT_TYPE_VALUE = "invalid header value"; | ||
| private static final String INVALID_CONTENT_TYPE_TEXT = "text"; | ||
| private static final String RELAXED_CONTENT_TYPE_TEXT = "text/plain"; | ||
|
|
||
| private static WebServer server; | ||
| private static WebClient client; | ||
|
|
||
| @BeforeAll | ||
| static void beforeAll() throws ExecutionException, InterruptedException, TimeoutException { | ||
| server = WebServer.builder( | ||
| Routing.builder() | ||
| .get("/invalidContentType", HeadersTest::invalidContentType) | ||
| .get("/invalidTextContentType", HeadersTest::invalidTextContentType) | ||
| .build() | ||
| ) | ||
| .build(); | ||
| server.start() | ||
| .toCompletableFuture() | ||
| .get(10, TimeUnit.SECONDS); | ||
|
|
||
| client = WebClient.builder() | ||
| .baseUri("http://localhost:" + server.port()) | ||
| .validateHeaders(false) | ||
| .keepAlive(true) | ||
| .build(); | ||
| } | ||
|
|
||
| // HTTP service with invalid Content-Type | ||
| private static void invalidContentType(ServerRequest request, ServerResponse response) { | ||
| response.addHeader(Http.Header.CONTENT_TYPE, INVALID_CONTENT_TYPE_VALUE) | ||
| .send(); | ||
| } | ||
|
|
||
| // HTTP service with Content-Type: text instead of text/plain | ||
| private static void invalidTextContentType(ServerRequest request, ServerResponse response) { | ||
| response.addHeader(Http.Header.CONTENT_TYPE, INVALID_CONTENT_TYPE_TEXT) | ||
| .send(); | ||
| } | ||
|
|
||
| @AfterAll | ||
| static void afterAll() throws ExecutionException, InterruptedException, TimeoutException { | ||
| if (server != null) { | ||
| server.shutdown() | ||
| .toCompletableFuture() | ||
| .get(10, TimeUnit.SECONDS); | ||
| } | ||
| } | ||
|
|
||
| // Verify that invalid content type causes an exception when being parsed | ||
| @Test | ||
| void testInvalidContentType() { | ||
| try { | ||
| client.get() | ||
| .path("/invalidContentType") | ||
| .request() | ||
| .await(10, TimeUnit.SECONDS); | ||
| fail("WebClient shall throw an exception"); | ||
| } catch (Exception ex) { | ||
| assertThat(ex, is(instanceOf(CompletionException.class))); | ||
| Throwable cause = ex.getCause(); | ||
| assertThat(cause, is(notNullValue())); | ||
| assertThat(cause, is(instanceOf(IllegalArgumentException.class))); | ||
| assertThat(cause.getMessage(), containsString(INVALID_CONTENT_TYPE_VALUE)); | ||
| } | ||
| } | ||
|
|
||
| // Verify that "text" content type causes an exception when being parsed in strict mode | ||
| @Test | ||
| void testInvalidTextContentTypeStrict() { | ||
| try { | ||
| client.get() | ||
| .path("/invalidTextContentType") | ||
| .request() | ||
| .await(10, TimeUnit.SECONDS); | ||
| } catch (Exception ex) { | ||
| assertThat(ex, is(instanceOf(CompletionException.class))); | ||
| Throwable cause = ex.getCause(); | ||
| assertThat(cause, is(notNullValue())); | ||
| assertThat(cause, is(instanceOf(IllegalArgumentException.class))); | ||
| assertThat(cause.getMessage(), containsString(INVALID_CONTENT_TYPE_TEXT)); | ||
| } | ||
| } | ||
|
|
||
| // Verify that "text" content type is transformed to "text/plain" in relaxed mode | ||
| @Test | ||
| void testInvalidTextContentTypeRelaxed() { | ||
| WebClient client = WebClient.builder() | ||
| .baseUri("http://localhost:" + server.port()) | ||
| .validateHeaders(false) | ||
| .keepAlive(true) | ||
| .mediaTypeParserRelaxed(true) | ||
| .build(); | ||
| WebClientResponse response = client.get() | ||
| .path("/invalidTextContentType") | ||
| .request() | ||
| .await(10, TimeUnit.SECONDS); | ||
| Optional<MediaType> maybeContentType = response.headers().contentType(); | ||
| assertThat(maybeContentType.isPresent(), is(true)); | ||
| assertThat(maybeContentType.get().toString(), is(RELAXED_CONTENT_TYPE_TEXT)); | ||
| } | ||
|
|
||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.