Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel button closes the Form Dialog by default #85

Merged
merged 7 commits into from
Sep 29, 2023

Conversation

DanicaSTFC
Copy link
Collaborator

Close #80

Copy link
Member

@lauramurgatroyd lauramurgatroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, just some minor docstring suggestions

eqt/ui/FormDialog.py Outdated Show resolved Hide resolved
examples/dialog_example_2.py Outdated Show resolved Hide resolved
DanicaSTFC and others added 2 commits September 29, 2023 11:47
Co-authored-by: Laura Murgatroyd <[email protected]>
@DanicaSTFC DanicaSTFC merged commit 9315808 into main Sep 29, 2023
6 checks passed
@DanicaSTFC DanicaSTFC deleted the Cancel_button_default branch September 29, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FormDialog Cancel button should close the dialog by default
2 participants