feat: Add support for calculating square root of a fixed point float #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(math_example.tact): add support for calculating square root of a fixed point float * feat(float.fc): implement sqrtFloat function to calculate the square root of a fixed point float * test(float.spec.ts): add tests for calculating square root of a fixed point float
ipromise2324
approved these changes
Dec 10, 2023
WaterSo0910
reviewed
Dec 10, 2023
There was a problem hiding this comment.
Great work! I'm really impressed with the progress and the quality of the code. I've added some comments within the code for further clarification and suggestions. Could you please take a look and address them when you have a moment? Your expertise and insights on these matters would be highly appreciated. Thanks for your excellent contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new feature to the math library that allows for calculating the square root of a fixed point float. It includes the implementation of the sqrtFloat function, along with tests and a CI workflow for automated testing.