Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #2 and #3 #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

SamDecrock
Copy link

First one is a real fix.
Second one is a hack, because I have no idea what the http parser wants to do with the socket object.
So I just gave it an empty socket object :-)

@rv-kip
Copy link

rv-kip commented Aug 31, 2012

The fix for issue #3 looks good. I did a different hack to fix and provided the dgram socket. Not sure which is correct.

...
self.requestParser = http.parsers.alloc();
self.requestParser.socket = self.server;
self.requestParser.reinitialize('request');
...

@luto
Copy link

luto commented Aug 30, 2013

Works for me. Thanks @SamDecrock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants