-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Edge Scripting API #145
Conversation
Initially thought I had to create this from scratch, but it seems that what was previously known (or available in the API docs) as "Compute scripts" which has now been transformed to "Edge scripts", which can be seen from the endpoints being the same: Example:
So the majority of the existing "Compute" models and endpoints should be moved and renamed to "Edge script" standards. This most likely would be classified as a breaking change, as all existing "Compute" would be moved to the "Edge Scripting" namespace, and would require an instance of the (As "compute scripts" can not be found searching through the API docs, I'm not sure if it is actually used by anyone. Still a breaking change if it's refactored though; |
0fb015e
to
093914f
Compare
fb97421
to
7e618a2
Compare
… endpoint; updated docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
Left todo is testing, and likely fix some issues along the way.
Edit
Tested and already looked good at 7b7d80c
Surprisingly, didn't have to do many code changes. Manual testing seems OK.
Think merge it tomorrow 💭 Don't forget to update the |
Fixes #144
TODO: