SetForceSSL Hostname parameter expects to be string not int #148
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @acohin 👋 Thank you for the PR! That bug has been in there for quite some time as well it seems. Good find. The fix seems fine as it corresponds to the API specs, but just to be sure I will test it manually later this evening. I'll keep you posted. |
ToshY
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hiya. Found a small bug while exploring some automation using the Bunny api.
The Bunny SetForceSSL endpoint expects the Hostname parameter to be string, while the
\ToshY\BunnyNet\Model\API\Base\PullZone\SetForceSSLclass defines this parameter as int.Simply changed the definition to string, this fixes the issue.