Cleanup Some Stuff, Increment Version (+0.0.1) #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Switches from bukkit to spigot-api
- Replaces GitHub Package Database with Glaremaster's Repository (Towny)
- Bump Towny dep to 0.100.4.0
- Bump ChestShop dep to 3.12.3-SNAPSHOT
- Build with Java 17
- Set sourceEncoding to UTF-8
- Set spigot-api to follow the `${bukkit.dependency.version}` property.
- Set afformentioned property to "1.20.6-R0.1-SNAPSHOT" (Matches ChestShop3's main POM.)
## Towny Class: Uses `Optional<File>` instead of pure `File` to handle loading the configuration. If a File is not provided by the Optional, disable the plugin, and free up datafolder to be culled. ## TownyUtils Class: Just adds a null-check
May have served a purpose for manually installing Towny. But no longer necessary when using Glaremaster's repository.
Really only useful if unloading after a normal onEnable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pom Changes
org.bukkit:bukkittoorg.spigotmc:spigot-apibukkit.dependency.version, 1.20.6-R0.1-SNAPSHOTDependency Install Script:
Removed. Unnecessary when using either a properly configured settings.xml for the GitHub Package Registry, or when using Glaremaster's repository.
Makes more sense to store it as a gist.
Towny Class:
Static Access
Make
datafolderandloadFile(String)non-static.Improve File Handling:
Uses
Optional<File>instead of pureFileto handle loading the configuration, and put in more effort to get a non-null File.If a File is not provided by the Optional, just disable the plugin.
Improve Disabling
Free up 'dataFile' and clear any events/listeners.
TownyUtils Class:
Just adds a null-check
Properties Class
Add 'final' keyword (these are never modified)