Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nation deleted message showing when a predeletenationevent is cancelled. #7383

Merged
merged 4 commits into from
Apr 26, 2024

Conversation

LlmDl
Copy link
Member

@LlmDl LlmDl commented Apr 26, 2024

Description:

Uses the nation.exists to determine if the removal of the nation was successful or not, and displays messages to match the outcome.


New Nodes/Commands/ConfigOptions:


Relevant Towny Issue ticket:

Closes #7380.
Supercedes #7381.


  • I have tested this pull request for defects on a server.

By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.

iscancelled.

Uses the nation.exists to determine if the removal of the nation was
successful or not, and displays messages to match the outcome.

Closes #7380.
Supercedes #7381.
@LlmDl LlmDl merged commit 9047b04 into master Apr 26, 2024
6 checks passed
@LlmDl LlmDl deleted the fix/nation_delete_message_better branch April 26, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nation deletion message is broadcast after cancelling PreDeleteNationEvent
1 participant