Use Java 21 on Jitpack #7746
Use Java 21 on Jitpack #7746
Conversation
|
Towny is currently set to use Java 17, in order to make things easier for servers still using MC 1.19. I'm not sure what the correct move is here, whether to bump is just for jitpack or to leave it be. |
|
Hey, thanks for taking a look at this PR! You don't need to bump it for JitPack. It just needs a >21 JVM to compile it, as the paper module is compiled against class file 65 (Java 21) and thus needs to be able to read/parse/whatever-it's-called it. Towny will still target Java 17; the files will be compiled to class file 61 (Java 17). I verified this with the jar compiled by JitPack from my branch: https://jitpack.io/com/github/PimvanderLoos/Towny/towny/master-fe30be79ec-1/towny-master-fe30be79ec-1.jar. |
|
Ah right, thank you.
…On Mon, Jan 27, 2025, 4:22 PM Pim van der Loos ***@***.***> wrote:
Hey, thanks for taking a look at this PR!
You don't need to bump it for JitPack. It just needs a >21 JVM to compile
it, as the paper module is compiled against class file 65 (Java 21) and
thus needs to be able to read/parse/whatever-it's-called it.
Towny will still target Java 17; the files will be compiled to class file
61 (Java 17). I verified this with the jar compiled by JitPack from my
branch:
https://jitpack.io/com/github/PimvanderLoos/Towny/towny/master-fe30be79ec-1/towny-master-fe30be79ec-1.jar
.
As such, this has no impact on compatibility and can still be used with
Java 17 on MC 1.19.
—
Reply to this email directly, view it on GitHub
<#7746 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGWZDCRGFSLAA7CJAXHSTL2M2WTPAVCNFSM6AAAAABV42LEZWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJXGAZDEMBSGQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
- Fixed format for "Owner" in MapHUD, courtesy of SulkyWhale with PR #7744. (First-Time Contributor!) - Use Java 21 on Jitpack, courtesy of PimvanderLoos with PR #7746. (First-Time Contributor!) - Bump org.jetbrains:annotations from 26.0.1 to 26.0.2. - Only fire successful teleport event on successful teleport, courtesy of Warrior with PR #7749. - Automatically add the 1.21.4 tree, flower, and moss blocks to the farm allowed blocks in existing configs, courtesy of Momshroom with PR #7750. - Automatic Config Edit: - "PALE_OAK_LOG,PALE_MOSS_BLOCK,PALE_MOSS_CARPET,PALE_OAK_SAPLING,PALE_HANGING_MOSS,PALE_OAK_LEAVES,CLOSED_EYEBLOSSOM,OPEN_EYEBLOSSOM," will be added to your config's farm plot's allowedBlocks section.
Description:
Updated the Java version used by JitPack from 17 to 21. The reason for this is:
towny-paper-providerdue toclass file has wrong version 65.0, should be 61.0. JitPack shows that the status isok, but it only actually publishes artifacts fortowny-folia-provider,towny-base-providers, andtowny-parent. Crucially, no artifact for thetownymodule is published, as you can see in the logs for 0.101.1.1.New Nodes/Commands/ConfigOptions:
Relevant Towny Issue ticket:
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.