Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change of execute function #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

change of execute function #14

wants to merge 2 commits into from

Conversation

agnel
Copy link

@agnel agnel commented Nov 10, 2012

Change of Execute Function

I re-wrote the execute function for the file to inject it according to the extension i.e .js or .css
if the extension is other than .js or .css it won't be loaded or even cached!

### Change of Execute Function
I re-wrote the *execute* function for the file to inject it according to the extension i.e **.js** or **.css**
if the extension is other than .js or .css it won't be loaded or even cached!
@djmc
Copy link
Contributor

djmc commented Nov 10, 2012

Also

if the extension is other than .js or .css it won't be loaded or even cached

It looks like this behaviour hasn't changed in your commit. However, would prefer that this functionality be kept, as it is used by us to store our handlebars templates (they're stored in HTML).

@djmc
Copy link
Contributor

djmc commented Nov 10, 2012

Other files types don't get injected, but they'll still get cached and made accessible. Read the README and see the section "Advanced File Loading".

@agnel
Copy link
Author

agnel commented Nov 10, 2012

Yeah, it'll be good for storing images!

On Sat, Nov 10, 2012 at 9:49 PM, Daniel McKenzie
[email protected]:

Other files types don't get injected, but they'll still get cached and
made accessible. Read the README and see the section "Advanced File
Loading".


Reply to this email directly or view it on GitHubhttps://github.com//pull/14#issuecomment-10256693.

@agnel
Copy link
Author

agnel commented Nov 10, 2012

There is a similar script -
basket.jshttp://addyosmani.github.com/basket.js/ -
but its limited only to storing javascripts!

On Sat, Nov 10, 2012 at 9:52 PM, agnel waghela [email protected]:

Yeah, it'll be good for storing images!

On Sat, Nov 10, 2012 at 9:49 PM, Daniel McKenzie <[email protected]

wrote:

Other files types don't get injected, but they'll still get cached and
made accessible. Read the README and see the section "Advanced File
Loading".


Reply to this email directly or view it on GitHubhttps://github.com//pull/14#issuecomment-10256693.

@djmc
Copy link
Contributor

djmc commented Nov 13, 2012

CSS injection will be great, I'll just await the newer code to be committed that takes into the above considerations and will take a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants