Remove setCurrentSlide api

Travelopia · Dec 2, 2024 · fbfa741 · fbfa741
1 parent 1ce3586
commit fbfa741
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 28 deletions.
diff --git a/src/lightbox/README.md b/src/lightbox/README.md
@@ -74,7 +74,3 @@ Open the lightbox.
 ### `close`
 
 Close the lightbox.
-
-### `setCurrentSlide`
-
-Set the current slide.
diff --git a/src/lightbox/tp-lightbox-nav-item.ts b/src/lightbox/tp-lightbox-nav-item.ts
@@ -36,7 +36,7 @@ export class TPLightboxNavItemElement extends HTMLElement {
 		}
 
 		// Set current slide.
-		this.lightbox.setCurrentSlide( this.getIndex() );
+		this.lightbox.currentIndex = Number( this.getIndex() ) ?? 1;
 
 		// Update navigation current item.
 		this.lightbox.updateNavCurrentItem();

diff --git a/src/lightbox/tp-lightbox.ts b/src/lightbox/tp-lightbox.ts
@@ -165,6 +165,13 @@ export class TPLightboxElement extends HTMLElement {
 			index = 1;
 		}
 
+		// dispatch slide-set event.
+		this.dispatchEvent( new CustomEvent( 'slide-set', {
+			detail: {
+				slideIndex: index,
+			},
+		} ) );
+
 		// Setting this attributes triggers a re-trigger.
 		this.setAttribute( 'index', index.toString() );
 	}
@@ -491,29 +498,6 @@ export class TPLightboxElement extends HTMLElement {
 		}
 	}
 
-	/**
-	 * Set the current slide index.
-	 *
-	 * @param {number} index Slide index.
-	 */
-	setCurrentSlide( index: number ): void {
-		// Check if slide index is valid.
-		if ( index > Number( this.getAttribute( 'total' ) ) || index <= 0 ) {
-			// Stop! It's not valid.
-			return;
-		}
-
-		// dispatch slide-set event.
-		this.dispatchEvent( new CustomEvent( 'slide-set', {
-			detail: {
-				slideIndex: index,
-			},
-		} ) );
-
-		// Set current slide index.
-		this.setAttribute( 'index', index.toString() );
-	}
-
 	/**
 	 * Update current item in navigation.
 	 */