EX-1142 fix access of null offset error and add validation on columns of last row #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does following -
get_block_wrapper_attributeson pre_render. It should be used on render hook.https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-includes/class-wp-block-supports.php#L98
https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-includes/class-wp-block.php#L515
It was not detected earlier as I was using a FSE theme which renders the content in "core/post-content" block by default. So, when we used it on simple classic theme, it started throwing error as we don't use
register_block_type.