Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WP-70 Table Header and Footer #7

Merged
merged 9 commits into from
Apr 30, 2024
Merged

WP-70 Table Header and Footer #7

merged 9 commits into from
Apr 30, 2024

Conversation

junaidbhura
Copy link
Contributor

No description provided.

@junaidbhura junaidbhura requested a review from i-am-chitti April 30, 2024 05:25
@i-am-chitti
Copy link
Member

@junaidbhura The block styling on editor side is breaking because as we are using apiVersion = 3, the block is rendered in iframe. That's why our editor.scss styling is not getting applied.
Refer to this commit - b9ce1be

i-am-chitti
i-am-chitti approved these changes Apr 30, 2024
View reviewed changes
src/blocks/table/edit.tsx Outdated Show resolved Hide resolved
@i-am-chitti i-am-chitti merged commit 14c1fb9 into master Apr 30, 2024
1 check passed
@i-am-chitti i-am-chitti deleted the WP-70/header-footer branch April 30, 2024 07:15
@i-am-chitti i-am-chitti mentioned this pull request Apr 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i-am-chitti i-am-chitti i-am-chitti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@junaidbhura @i-am-chitti