Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoriza morador comprovante #140

Merged
merged 6 commits into from
Jul 22, 2024
Merged

Conversation

Vinigperuzzi
Copy link
Contributor

@Vinigperuzzi Vinigperuzzi commented Jul 22, 2024

Título

Autorização de moradores nas telas dos comprovantes

descrição

Agora acontece um redirecionamento com a devida mensagem caso um morador tente acessar via url as telas de cobranças de outros moradores.

Resolve a issue #139

Copy link
Contributor

@ruliancruz ruliancruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acredito que esteja tudo ok, aprovado.

Copy link
Contributor

@RyanOxon RyanOxon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix importante no sistema. Acho q o autorize_resident poderia ter sido feito num outro controller e bill/receipts controller herdariam dele. Evitando assim repeticao de codigo. Mas acredito que do jeito que esta, ja esta otimo!

Co-authored-by: Lucas Oliveira <[email protected]>
@DaniloRibeiro07 DaniloRibeiro07 self-requested a review July 22, 2024 15:29
Copy link
Contributor

@DaniloRibeiro07 DaniloRibeiro07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aprovado!

@Vinigperuzzi Vinigperuzzi merged commit 505bf6e into main Jul 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants