Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took the liberty of doing some of the changes we discussed. This includes using
CplugHostContext
everywhere instead of AUv2Plugin, CLAPPlugin and so on, removingCPLUG_NUM_PARAMS
and callingcplug_getParamCount()
instead, adding the host context pointer tocplug_createPlugin()
. One bit of awkwardness is that I had to declarecplug_createPlugin()
incplug.h
as taking avoid*
argument instead ofCplugHostContext*
due toCplugHostContext
being declared later.That takes care of the tedious part that had to be done before you can implement
propertyChanged()
.I also changed
cplug_log()
, now it's defined by a macro, the idea is that if you don't define it it defaults to afprintf(stderr, ...)
, but if you do define it prior to#include <cplug.h>
in your plugin then you can define it to a function in your plugin code much like the originalcplug_log()
function which can write to a file, for instance by doing#define cplug_log myplugin_log
. Arguably it could be renamed toCPLUG_LOG()
now that it's a macro, but I leave this choice up to you, I myself occasionally keep function alias macros as small caps because they call only functions.