Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore inbox-current-tags-alist from inbox buffer to WIP clarifying buffer #151

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

douo
Copy link

@douo douo commented May 17, 2023

When using org-gtd-process-inbox, org-gtd creates a new buffer for each item but does not bring the heading metadata from inbox.org. This causes org-mode to be unable to find tags from the current buffer. This PR resolved #145 in my situation.

@Trevoke
Copy link
Owner

Trevoke commented May 17, 2023

Hi @douo , thank you for looking into this!

Part of the intent with the upgrade to v3 is to stop depending as much on the hardcoded values in those files -- your tags are yours, and they are not required to make org-gtd work (the only exception is this default value for the organize-hooks, and maybe that's a bad default value).

The reason this decision was made is because I thought that your tags would always be your own, and therefore that you would just want to use org-mode to set the tags with org-tags-alist - as described in here https://orgmode.org/manual/Setting-Tags.html

If I made the wrong decision, and you have tags which you don't want to see in org-gtd, then we should create a customizable variable org-gtd-tags-alist instead. The reason for that is because the inbox should not be the home of your behavior-based settings - I did this in earlier versions of org-gtd because I did not know enough about how org-mode worked, but I have since learned a lot.

Eventually, while I would love to see folks who use org-gtd for years because it works very well for them, I also want to make it possible / seamless for people to move away from org-gtd to their own system, if they discover they have different needs.

So: is it possible for you to start using org-tags-alist in your configuration, or should we create org-gtd-tags-alist instead?

@douo
Copy link
Author

douo commented May 17, 2023

Hi @Trevoke, org-current-tags-alist is not a personal use variable of mine. It is an org-mode defined variable assigned to all tags belonging to the current buffer. If this variable dose not sync to clarify buffer. org-set-tags-command can not work properly.

...
;; Version: 9.6.6
....
defvar-local org-current-tag-alist nil
  "Alist of all tag groups in current buffer.
This variable takes into consideration `org-tag-alist',
`org-tag-persistent-alist' and TAGS keywords in the buffer.")

I completely concur that this PR appears to be somewhat hardcoded. The primary issue at hand is that the tags defined in the inbox file, using the following syntax, are not being properly brought into WIP Clarifying buffer.

#+TAGS:

@Trevoke
Copy link
Owner

Trevoke commented May 17, 2023

Hi @douo , sorry, let me write fewer words.

Org-GTD does not want you to use #+TAGS:.

Org-GTD wants you to use org-tag-alist.

Are you able to move your tags from #+TAGS: to (setq org-tag-alist ....) ?

If not, I have a better solution than this PR.

@douo
Copy link
Author

douo commented May 17, 2023

Forcing the use of org-tag-alist may not be a good idea, as I use Org not only for GTD but also for my writing system. These two systems require different tag sets.

@Trevoke
Copy link
Owner

Trevoke commented May 17, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

org-current-tag-alist is nil in org-gtd-clarify-mode
2 participants