feat: Add option to skip version bumping.

[tomfrenken]

Hey all,

in our pipeline we already bumped the version of our package.json in a previous step, therefore we would like to skip bumping the version in this action.

This PR should introduce a simple option to do so.

[tomfrenken]

Hey @TriPSs, do you think we could add this option? :)

[TriPSs]

How different would this be than setting version file to an empty string?

[tomfrenken]

Well, with an empty string we would cause the following error:

throw new Error(`File extension "${ext}" from file "${file}" is not supported`)

And even if we use skip-version-file and instead set a fallback-version to the one we actually want to use, the version is still bumped as is.

if (skipVersionFile || skipCommit) {
      core.info('Using GIT to determine the new version')
      const versioning = await handleVersioningByExtension( // this function bumps the version currently
        'git',
        versionFile,
        versionPath,
        recommendation.releaseType,
      )

[tomfrenken]

I just added another conditional to set the newVersion to the oldVersion, as the newVersion property was only set when you are bumping (which we are trying not to do), and then later on this property is used for the changelog generation and therefore necessary.

[TriPSs]

Although I find it a bit weird I do not see any harm in support things, could you do the following:

1. Commit to this repo following conventional commits
2. Process comments
3. Add tests

[tomfrenken]

Thanks for the review, it wasn't entirely clear to me how all the testing in this repo behaves, but I believe my implementation should test it properly according to the existing standards.

Regarding your first point:

Commit to this repo following conventional commits

I did create the PR with a conventional commit message and would usually squash merge & remove all commit messages while squashing, would that work for you, or how exactly should I proceed?

[tomfrenken]

Also please approve the workflow run again :)

[TriPSs]

I did create the PR with a conventional commit message and would usually squash merge & remove all commit messages while squashing, would that work for you, or how exactly should I proceed?

We could do that, regarding the test: should the tag it creates not be the same as the version in the file?

[TriPSs]

The test is also failing, it's creating a tag with vnull now

[tomfrenken]

Indeed, both the test and the implementation need some changes, currently the old version is only loaded after using the bump function, I'll make some more changes.

[tomfrenken]

Alright, I've adjusted the test as per your suggestion and also changed the classes to use a proper constructor instead of the init method, now the files are read and parsed at initialization, this way the oldVersion is accessible independently of bumping.

[TriPSs]

@tomfrenken you can also run the actions locally, see the README. My preference would be to only implement your feature here and leave existing code more as is (So keep the init, as I prefer to only pass args once and not for each class separate).

[tomfrenken]

@TriPSs thanks for the abstract method suggestion, great idea.
I've implemented the change and also added additional tests for corner cases.

[TriPSs]

Thanks already for your work!

[tomfrenken]

Awesome, moving the logic to the version function also removed the code duplication, and the improved conditional logic is also way cleaner.

[TriPSs]

Thanks for the PR 🎉

[tomfrenken]

Thanks for the quick reviews!