Skip to content

Commit

Permalink
Improvements (#139)
Browse files Browse the repository at this point in the history
  • Loading branch information
TriPSs authored Aug 25, 2023
2 parents c85d921 + 9b70248 commit 0c29a66
Show file tree
Hide file tree
Showing 19 changed files with 32 additions and 22 deletions.
2 changes: 1 addition & 1 deletion packages/changelog-notify/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"publish": {
"executor": "nx:run-commands",
"options": {
"command": "npm publish ./dist/packages/changelog-notify --access public"
"command": "npm publish ./dist/packages/changelog-notify --access public || true"
}
}
},
Expand Down
2 changes: 1 addition & 1 deletion packages/core/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"publish": {
"executor": "nx:run-commands",
"options": {
"command": "npm publish ./dist/packages/core --access public"
"command": "npm publish ./dist/packages/core --access public || true"
}
}
},
Expand Down
2 changes: 1 addition & 1 deletion packages/e2e-runner/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"publish": {
"executor": "nx:run-commands",
"options": {
"command": "npm publish ./dist/packages/e2e-runner --access public"
"command": "npm publish ./dist/packages/e2e-runner --access public || true"
}
}
},
Expand Down
7 changes: 6 additions & 1 deletion packages/e2e-runner/src/executors/run/run.impl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { RunCommandsOptions } from 'nx/src/executors/run-commands/run-commands.i
import { NxTarget, NxTargetOptions } from './utils/nx-target'

export interface RunOptions {
runner: 'cypress' | 'playwright' | 'run-commands'
runner: 'cypress' | 'playwright' | '@nx/playwright' | 'run-commands'
runnerTarget?: string
watch?: boolean
targets: NxTargetOptions[]
Expand Down Expand Up @@ -46,6 +46,11 @@ export async function endToEndRunner(
// eslint-disable-next-line @typescript-eslint/no-var-requires
const playwrightExecutor = require('@nx-extend/playwright/src/executors/test/test.impl').default

success = (await playwrightExecutor(rest, context)).success
} else if (runner === '@nx/playwright') {
// eslint-disable-next-line @typescript-eslint/no-var-requires
const playwrightExecutor = require('@nx/playwright/src/executors/playwright/playwright').default

success = (await playwrightExecutor(rest, context)).success
} else if (runner === 'run-commands') {
// eslint-disable-next-line @typescript-eslint/no-var-requires
Expand Down
2 changes: 1 addition & 1 deletion packages/firebase-hosting/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
"publish": {
"executor": "nx:run-commands",
"options": {
"command": "npm publish ./dist/packages/firebase-hosting --access public"
"command": "npm publish ./dist/packages/firebase-hosting --access public || true"
}
}
},
Expand Down
2 changes: 1 addition & 1 deletion packages/gcp-cloud-run/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"publish": {
"executor": "nx:run-commands",
"options": {
"command": "npm publish ./dist/packages/gcp-cloud-run --access public"
"command": "npm publish ./dist/packages/gcp-cloud-run --access public || true"
}
}
},
Expand Down
2 changes: 1 addition & 1 deletion packages/gcp-deployment-manager/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"publish": {
"executor": "nx:run-commands",
"options": {
"command": "npm publish ./dist/packages/gcp-deployment-manager --access public"
"command": "npm publish ./dist/packages/gcp-deployment-manager --access public || true"
}
}
},
Expand Down
2 changes: 1 addition & 1 deletion packages/gcp-functions/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
"publish": {
"executor": "nx:run-commands",
"options": {
"command": "npm publish ./dist/packages/gcp-functions --access public"
"command": "npm publish ./dist/packages/gcp-functions --access public || true"
}
}
},
Expand Down
2 changes: 1 addition & 1 deletion packages/gcp-secrets/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"publish": {
"executor": "nx:run-commands",
"options": {
"command": "npm publish ./dist/packages/gcp-secrets --access public"
"command": "npm publish ./dist/packages/gcp-secrets --access public || true"
}
}
},
Expand Down
2 changes: 1 addition & 1 deletion packages/gcp-storage/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"publish": {
"executor": "nx:run-commands",
"options": {
"command": "npm publish ./dist/packages/gcp-storage --access public"
"command": "npm publish ./dist/packages/gcp-storage --access public || true"
}
}
},
Expand Down
2 changes: 1 addition & 1 deletion packages/gcp-task-runner/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"publish": {
"executor": "nx:run-commands",
"options": {
"command": "npm publish ./dist/packages/gcp-task-runner --access public"
"command": "npm publish ./dist/packages/gcp-task-runner --access public || true"
}
}
},
Expand Down
2 changes: 1 addition & 1 deletion packages/github-pages/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"publish": {
"executor": "nx:run-commands",
"options": {
"command": "npm publish ./dist/packages/github-pages --access public"
"command": "npm publish ./dist/packages/github-pages --access public || true"
}
}
},
Expand Down
2 changes: 1 addition & 1 deletion packages/playwright/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"publish": {
"executor": "nx:run-commands",
"options": {
"command": "npm publish ./dist/packages/playwright --access public"
"command": "npm publish ./dist/packages/playwright --access public || true"
}
}
},
Expand Down
2 changes: 1 addition & 1 deletion packages/pulumi/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"publish": {
"executor": "nx:run-commands",
"options": {
"command": "npm publish ./dist/packages/pulumi --access public"
"command": "npm publish ./dist/packages/pulumi --access public || true"
}
}
},
Expand Down
13 changes: 9 additions & 4 deletions packages/pulumi/src/executors/up/up.impl.ts
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
import { ExecutorContext } from '@nx/devkit'
import { buildCommand } from '@nx-extend/core'
import { buildCommand, USE_VERBOSE_LOGGING } from '@nx-extend/core'
import { execSync } from 'child_process'
import { which } from 'shelljs'

export interface UpOptions {
stack?: string,
skipPreview?: boolean,
skipPreview?: boolean
yes?: boolean
suppressOutputs?: boolean
json?: boolean
}

export default async function creatExecutor(
Expand All @@ -21,10 +23,13 @@ export default async function creatExecutor(

execSync(
buildCommand([
'pulumi up',
'pulumi up',
options.stack && `--stack=${options.stack}`,
options.skipPreview && '--skip-preview',
options.yes && '--yes'
options.yes && '--yes',
options.suppressOutputs && '--suppress-outputs',
USE_VERBOSE_LOGGING && '--debug',
options.json && '--json'
]),
{
cwd: sourceRoot,
Expand Down
2 changes: 1 addition & 1 deletion packages/strapi/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"publish": {
"executor": "nx:run-commands",
"options": {
"command": "npm publish ./dist/packages/strapi --access public"
"command": "npm publish ./dist/packages/strapi --access public || true"
}
}
},
Expand Down
2 changes: 1 addition & 1 deletion packages/terraform/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"publish": {
"executor": "nx:run-commands",
"options": {
"command": "npm publish ./dist/packages/terraform --access public"
"command": "npm publish ./dist/packages/terraform --access public || true"
}
}
},
Expand Down
2 changes: 1 addition & 1 deletion packages/translations/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"publish": {
"executor": "nx:run-commands",
"options": {
"command": "npm publish ./dist/packages/translations --access public"
"command": "npm publish ./dist/packages/translations --access public || true"
}
}
},
Expand Down
2 changes: 1 addition & 1 deletion packages/vercel/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"publish": {
"executor": "nx:run-commands",
"options": {
"command": "npm publish ./dist/packages/vercel --access public"
"command": "npm publish ./dist/packages/vercel --access public || true"
}
}
},
Expand Down

0 comments on commit 0c29a66

Please sign in to comment.