-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pulumi): Support --yes
and --skipPreview
options
#143
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit facade9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Thanks for the PR, looks good as is. One thing, please do use conventional commits as these changes (like the previous) will now not show up the changelog. |
Interesting. What are "conventional commits"? Never heard of that before actually. |
I see I'm also missing the contributing here 😅, here you can find more info: https://www.conventionalcommits.org/en/v1.0.0/ |
Oh, interesting! That's cool. I'll definitely start using that myself. What can we do about the existing commits though? I'm not a GIT mastermind. Perhaps we could squash the pull request when we merge it, and then set a commit message there? |
Yea, we can update the PR name that will also work, good one. |
--yes
and --skipPreview
options
Ah, didn't see the parenthes stuff in the spec. Thanks for renaming it ❤️ |
Yes that's the scope, I always put the package name in it. Thanks for the PR! |
Bit of a shame that the changelog still did not pick it up 😅 Maybe it has to do with the fact that it was a merge commit 🤔 |
Yeah maybe it should have been a squash. Hard to tell. Thanks for teaching me about conventional commits though! |
Fixes #142.
Marked as draft, as I am not sure how to test it. If you think it's okay to merge without testing, let me know.