fix empty space on json editor details text

TrianguloY · Feb 18, 2025 · 797ad6c · 797ad6c
1 parent 4a9c2d2
commit 797ad6c
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 2 deletions.
diff --git a/app/src/main/java/com/trianguloy/urlchecker/activities/JsonEditorActivity.java b/app/src/main/java/com/trianguloy/urlchecker/activities/JsonEditorActivity.java
@@ -6,6 +6,7 @@
 import android.view.Menu;
 import android.view.MenuItem;
 import android.view.View;
+import android.view.ViewGroup;
 import android.widget.TextView;
 import android.widget.Toast;
 
@@ -28,7 +29,7 @@ public class JsonEditorActivity extends Activity {
 
     private JsonEditorInterface provider;
     private TextView editor;
-    private View info;
+    private ViewGroup info;
 
     // ------------------- listeners -------------------
 
@@ -53,6 +54,7 @@ protected void onCreate(Bundle savedInstanceState) {
         }
 
         info = findViewById(R.id.info);
+        AndroidUtils.limitHeight(info);
         this.<TextView>findViewById(R.id.description).setText(provider.getEditorDescription());
 
         editor = findViewById(R.id.data);

diff --git a/app/src/main/java/com/trianguloy/urlchecker/utilities/methods/AndroidUtils.java b/app/src/main/java/com/trianguloy/urlchecker/utilities/methods/AndroidUtils.java
@@ -16,6 +16,8 @@
 import android.util.TypedValue;
 import android.view.MenuItem;
 import android.view.View;
+import android.view.ViewGroup;
+import android.widget.LinearLayout;
 import android.widget.TextView;
 import android.widget.Toast;
 
@@ -258,4 +260,17 @@ public void onClick(View ignored) {
         text.replace(start, end, url);
         return text;
     }
+
+    /** Reduces the height of a view to their children's size (if less) */
+    static void limitHeight(ViewGroup view) {
+        view.post(() -> {
+            int childHeight = 0;
+            for (int i = 0; i < view.getChildCount(); i++) {
+                childHeight += view.getChildAt(i).getHeight();
+            }
+            if (view.getHeight() > childHeight) {
+                view.setLayoutParams(new LinearLayout.LayoutParams(view.getWidth(), childHeight));
+            }
+        });
+    }
 }
diff --git a/app/src/main/res/layout/activity_json_editor.xml b/app/src/main/res/layout/activity_json_editor.xml
@@ -9,7 +9,7 @@
         android:layout_width="match_parent"
         android:layout_height="0dp"
         android:layout_weight="1"
-        android:fillViewport="true">
+        android:fillViewport="false">
 
         <TextView
             android:id="@+id/description"